Diagrams in models of discrete double theories #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epatters
added
enhancement
epatters
changed the title
epatters
requested changes
Nov 12, 2024
Member
epatters
left a comment
epatters
left a comment
There was a problem hiding this comment.
Thanks Kevin! I'll review this PR more thoroughly soon but a few quick comments now:
- To fix the CI failures, run
cargo fmtandcargo clippy - Remove the spurious
printlnthat crept intomodel_morphism.rsand the whitespace added tocolumn.rs
Collaborator
Author
|
@epatters thanks, should be fixed! |
epatters
force-pushed
the
discrete_diagrams
branch
from
57c7f62 to
da7bb46
Compare
epatters
force-pushed
the
discrete_diagrams
branch
from
da7bb46 to
45d257e
Compare
epatters
approved these changes
Nov 13, 2024
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #236 by implementing discrete diagrams which own their domain, a free model, and their mapping, along with simple validation that the mapping is actually defined everywhere on the domain.