-
Notifications
You must be signed in to change notification settings - Fork 40
Stock-flow diagrams with signed links #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
debe992 to
6385bac
Compare
|
@epatters I'm trying to get + and - to appear on positive / negative links in the visualisation, and it's proving very frustrating. What's currently confusing me even more is the file |
b2c42d0 to
76be97f
Compare
76be97f to
3908d5c
Compare
3908d5c to
0a71db0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tim, this looks great so far!
My only major request is that we create a new theory in the frontend rather than replacing the old one. There are at least three reasons for this:
- It won't break any existing models that use the old theory
- More importantly, it's consistent with our philosophy of having a family of languages of increasing expressiveness and complexity, with migrations between them, like we've done with CLDs. (As we've discussed, the UX for these migrations currently isn't great, but that's a separate problem.)
- More importantly still, in my perusal of stock-flow diagrams in the wild, the links very often don't have signs, and thus keeping the old theory around is a way of respecting the tradition while still being able to go beyond it
Argh, there appears to be a regression on next in
On prod they look fine. @kasbah, I wonder if this is an unintended consequence of #888? I don't have time to investigate right now. But note @tim-at-topos that the fun ube color is specific to places in Petri nets: the CSS selector is |
My observations differ. Importantly I don't see any regression from prod to next.
There is a conflict between
EDIT: This is also due to a similar conflict. It can be worked around with I made an issue for it: #913 |
1f67b98 to
6ecb11b
Compare
That must be it, although I do see different behavior in prod and next/local for Petri nets. In any case, I've got a fix in #915. |
Also, test that the new models validate.
06bd8d6 to
c4c15ac
Compare
epatters
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! @tim-at-topos, I made a few small cleanups (see new commits).
I've also rebased off main, which includes my fixes to the CSS for SVG graph visualizations (#915). However, instead of delaying further, I'm going to merge this as-is and let you follow up with a PR to add the positive/negative signs to the stock-flow visualization. Thanks!




Enriching the theory of stock-flow diagrams to have positive and negative links, instead of merely links. Includes a mass-action simulation analysis.