Skip to content

Open new documents in a split pane with the parent #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epatters merged 1 commit into from
Dec 16, 2025
Merged

Open new documents in a split pane with the parent #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions packages/frontend/src/page/document_menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import invariant from "tiny-invariant";

import { IconButton } from "catcolab-ui-components";
import { createAnalysis } from "../analysis";
import { type DocRef, type LiveDoc, useApi } from "../api";
import { type DocRef, DocumentType, type LiveDoc, useApi } from "../api";
import { DocumentTypeIcon } from "../components/document_type_icon";
import { createDiagram } from "../diagram";
import {
Expand All @@ -24,14 +24,22 @@ import { TheoryLibraryContext } from "../theory";
export function DocumentMenu(props: {
liveDoc: LiveDoc;
docRef: DocRef;
onDocCreated?: () => void;
onDocCreated?: (docType: DocumentType, refId: string) => void;
onDocDeleted?: () => void;
}) {
const api = useApi();

const navigate = useNavigate();
const docType = () => props.liveDoc.doc.type;

const handleDocCreated = (docType: DocumentType, refId: string) => {
if (props.onDocCreated) {
props.onDocCreated(docType, refId);
} else {
navigate(`/${docType}/${refId}`);
}
};

const onNewDiagram = async () => {
let modelRefId: string | undefined;
switch (props.liveDoc.doc.type) {
Expand All @@ -47,8 +55,7 @@ export function DocumentMenu(props: {
}

const newRef = await createDiagram(api, api.makeUnversionedRef(modelRefId));
props.onDocCreated?.();
navigate(`/diagram/${newRef}`);
handleDocCreated("diagram", newRef);
};

const onNewAnalysis = async () => {
Expand All @@ -57,8 +64,7 @@ export function DocumentMenu(props: {
invariant(docType !== "analysis", "Analysis cannot be created on other analysis");

const newRef = await createAnalysis(api, docType, api.makeUnversionedRef(docRefId));
props.onDocCreated?.();
navigate(`/analysis/${newRef}`);
handleDocCreated("analysis", newRef);
};

const theories = useContext(TheoryLibraryContext);
Expand Down
5 changes: 4 additions & 1 deletion packages/frontend/src/page/document_page_sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,10 @@ function DocumentsTreeLeaf(props: {
<DocumentMenu
liveDoc={props.doc.liveDoc}
docRef={props.doc.docRef}
onDocCreated={props.refetchDoc}
onDocCreated={(docType, refId) => {
props.refetchDoc();
navigate(`/${createLinkPart(props.doc)}/${docType}/${refId}`);
}}
onDocDeleted={async () => {
const deletedRefId = props.doc.docRef.refId;
const isPrimaryDeleted = deletedRefId === primaryRefId();
Expand Down