feat: Add Symlink support for fuse#29
Open
lexiismadd wants to merge 28 commits intoTorBox-App:mainfrom
Open
Conversation
Contributor
|
Thanks for submitting, let me take a look into this and do some testing. |
Wamy-Dev
requested changes
Jul 26, 2025
Contributor
There was a problem hiding this comment.
Can you write about the benefits of using symlinking with FUSE?
Contributor
There was a problem hiding this comment.
Should the default be off?
| MOUNT_REFRESH_TIME = MountRefreshTimes[MOUNT_REFRESH_TIME].value No newline at end of file | ||
| MOUNT_REFRESH_TIME = MountRefreshTimes[MOUNT_REFRESH_TIME].value | ||
|
|
||
| DEBUG_MODE = os.getenv("DEBUG_MODE", False) in [True,'true'] |
Contributor
There was a problem hiding this comment.
Should just wrap in a bool to convert it
Contributor
There was a problem hiding this comment.
Pretty sure it works like this, but needs testing
| logging.info("Unmounted successfully.") | ||
|
|
||
|
|
||
| def create_symlink_in_symlink_path(vfs_path, symlink_path): |
| get_symlink_data = getAllData('symlinks')[0] | ||
| except: | ||
| get_symlink_data = [] | ||
| # logging.debug(f"Symlink db:\n{get_symlink_data}") |
Contributor
There was a problem hiding this comment.
keeping the debug would be helpful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add symlinking capabilities to fuse mount method
Adds new (optional) .env variable "SYMLINK_PATH" which instructs app to create a symlink to files when they are created in fuse vfs.
Replaces bug found in previous pull request #28