Skip to content

Conversation

@fepegar
Copy link
Member

@fepegar fepegar commented Aug 8, 2025

Applying

again as it was not the culprit of the memory leak, as discussed in that pull request.

Thanks again @StijnvWijn for your investigation and your work on this important feature.

@fepegar
Copy link
Member Author

fepegar commented Aug 8, 2025

@StijnvWijn, please let me know if you're happy for me to merge this.

@StijnvWijn
Copy link
Contributor

@fepegar Yess, awesome looks good!
Do you want to put the fix for the memory leak into another PR?

@fepegar
Copy link
Member Author

fepegar commented Aug 9, 2025

Thanks for checking!

The memory leak is not an issue since

What might be nice is adding that check again but without the memory leak. Is that what you mean?

In any case that's indeed out of the scope of this PR.

@fepegar fepegar merged commit 2d661a7 into main Aug 9, 2025
30 checks passed
@fepegar fepegar deleted the re-apply-no-copy-crop branch August 9, 2025 19:58
@fepegar
Copy link
Member Author

fepegar commented Aug 9, 2025

@allcontributors please add @StijnvWijn for bug

@allcontributors
Copy link
Contributor

@fepegar

I've put up a pull request to add @StijnvWijn! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants