-
Notifications
You must be signed in to change notification settings - Fork 10
feat(autogram): Add DiagonalSparseTensor.
#466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
PierreQuinton
wants to merge
146
commits into
dev-new-engine
Choose a base branch
from
block-diagonal-tensor
base: dev-new-engine
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,245
−13
Draft
Changes from 1 commit
Commits
Show all changes
146 commits
Select commit
Hold shift + click to select a range
32ef75e
Add `DiagonalSparseTensor` with the default fallback to dense mechanism.
PierreQuinton 5c76d69
Ignore mypy
PierreQuinton 34f4dce
Remove useless comment.
PierreQuinton a0b7ffc
Change repr
PierreQuinton f476b29
revert removing `__init__`
PierreQuinton 447d714
Give implementation for pointwise
PierreQuinton 85556a8
Add decorator to handle other functions. Add two examples of such fun…
PierreQuinton c5f868c
Improve naming.
PierreQuinton 7f5c097
Merge branch 'main' into block-diagonal-tensor
ValerianRey efa8019
improve
PierreQuinton e36b3c5
Remove inplace functions from the list of pointwise functions (they s…
PierreQuinton 018a994
Fix `to_dense`
PierreQuinton e91323c
Verify input.
PierreQuinton f728153
Make a builder for DSPs and move checks in it. This should always be …
PierreQuinton b2b5d7a
Implement pointwise and inplace pointwise in `_HANDLED_FUNCTIONS`.
PierreQuinton 2b80788
Move Pointwise functions definitions.
PierreQuinton 85c8e41
Clean filed of DST, remove virtual shape, it is just the shape, and m…
PierreQuinton 123d2ce
Merge branch 'dev-new-engine' into block-diagonal-tensor
ValerianRey 7c0bc45
Use DST for initial jac_output
ValerianRey 8509a33
Add test for to_dense and inplace_pointwise
PierreQuinton 0eed3a3
Revert "Clean filed of DST, remove virtual shape, it is just the shap…
PierreQuinton 55a7cbc
Make `contiguous_data` and `v_to_p` public.
PierreQuinton 5796236
Merge remote-tracking branch 'origin/block-diagonal-tensor' into bloc…
PierreQuinton 0ede4ce
Add linting comment when importing aten
ValerianRey bb165b0
Specify indexing="ij" in meshgrid call
ValerianRey 6e57a3f
Use tuple for v_indices_grid
ValerianRey 8351af5
Use lists for _POINTWISE_FUNCTIONS and _IN_PLACE_POINTWISE_FUNCTIONS
ValerianRey 278bf24
Sort _POINTWISE_FUNCTIONS and _IN_PLACE_POINTWISE_FUNCTIONS
ValerianRey d14a1a5
Fix pointwise function override
ValerianRey 17abe7f
Make `contiguous_data` and `v_to_p` public.
PierreQuinton 6bbd702
Use wraps decorator instead of update_wrapper
ValerianRey fac5f7d
Make densification explicit in tests before assert_close
ValerianRey 68bb2a3
Revert "Make `contiguous_data` and `v_to_p` public."
ValerianRey 3db55c3
Add pow implementation for DST
ValerianRey 90b205c
Remove type hint of __torch_dispatch__ so that mypy stops complaining
ValerianRey 2b36084
Make signature of to_dense match that of Tensor.to_dense.
ValerianRey 6236baa
Change type: ignore so that mypy doesn't complain
ValerianRey 6d28918
Add unsqueeze_default implementation for DST
ValerianRey f4a436c
Add more info in the print when falling back to dense
ValerianRey ad4d843
Add implementation for trivial views
ValerianRey b353ff1
Add expand_default, div_Scalar, and slice_Tensor
ValerianRey d640266
Add mul_Tensor and transpose_int
ValerianRey 6145e4b
Use diagonal_sparse_tensor in view_default
ValerianRey 444e7cd
Use DiagonalSparseTensor type hint when applicable
ValerianRey 5c859b5
Add debug_info
ValerianRey 960de60
Improve error message in view_default
ValerianRey e12080e
Add multi-dimensional v_to_p
ValerianRey a38f907
Rename mean and sum to mean_default and sum_default
ValerianRey b7a3f53
Fix condition and comment in diagonal_sparse_tensor
ValerianRey aa3d8a0
Improve implementation of view
ValerianRey c49411f
Implement `einsum` for `v_to_p: list[int]`
PierreQuinton 6c0e9ec
Factor access to physical shape in view.
PierreQuinton 2f774db
rename `physical_to_virtual` to `p_to_vs`.
PierreQuinton 7344118
Refactor p_to_vs.
PierreQuinton 0884495
Adapt `einsum` to `v_to_p: list[list[int]]`
PierreQuinton a5fda15
Rename `v_to_p` to `v_to_ps`
PierreQuinton d03d3a4
Remove diagonal_sparse_tensor, remove to_diagonal_sparse_tensor
ValerianRey 3bf75fb
Remove aten.div.Scalar from _POINTWISE_FUNCTIONS
ValerianRey 35e841a
Fix set union to be able to handle empty list of sets
ValerianRey 2d37031
fix type hint of bmm_default
ValerianRey 7a84940
Add mm_default
ValerianRey 30adf30
Use to_dense when comparing result of einsum in test_einsum
ValerianRey e6ce46e
Make einsum work with DST only, re-add to_diagonal_sparse_tensor
ValerianRey 5253363
Remove list comprehension
PierreQuinton 75d138c
Add sortin function
PierreQuinton f33107b
Add test_view2 and new parametrization for test_view
ValerianRey 17047f6
Add test_sort_dst
ValerianRey 6d1cfa5
Revert "Remove list comprehension"
ValerianRey a5390b7
Rename map to mapping in sort_dst
ValerianRey 2cc95ea
Use empty ps to indicate virtual dim of size one.
ValerianRey ef5a2b1
Remove outdated todo in einsum
ValerianRey ea7d4dd
Improve implementation of sort_dst
ValerianRey 8403b11
Restructure packages
ValerianRey f2b2ef6
Make _HANDLED_FUNCTIONS and implements class attributes of DST
ValerianRey 97213eb
Move pointwise function implementations to the end of the file and av…
ValerianRey 866b4b1
Uniformize name of physical
ValerianRey b73de79
Improve print when falling back to dense
ValerianRey e393096
Rename first_sort to encode_by_order and improve its docstring
ValerianRey 7a8b8a4
Improve repr of DST
ValerianRey 28c72ed
Minor formatting fix
ValerianRey 1c1885c
Move _strides to where it is used:
ValerianRey 09f3efc
Minor reformating
ValerianRey 5703fd2
Add check that v_to_ps are correctly encoded
ValerianRey 8a13d49
Fix to_diagonal_sparse_tensor to not create physical with dim of size 1.
ValerianRey 82d4b33
Add function to create a DST without having to care about dims of siz…
ValerianRey 9d21a6c
Remove test_view and rename test_view2 to test_view
ValerianRey 42e8228
Minor reformatting
ValerianRey 33194c0
Move p_to_vs outside of DiagonalSparseTensor and rename it p_to_vs_fr…
ValerianRey 21ca8e3
Add get_groupings, fix_ungrouped_dims, and use it in constructor
ValerianRey 15a615f
Add check of maximal grouping in DST.__init__
ValerianRey ee8e181
Use make_dst in einsum
ValerianRey 8992d3f
Add possibility to slice dimension of size 1.
ValerianRey cf4f950
Fix to_dense when a pdims is []
ValerianRey ebffc3c
Stop creating index tensors on data device. I think it's ok / faster …
ValerianRey fe84b80
Rename current_product to current_size
ValerianRey 92bcaa6
Add unsquash_pdim
ValerianRey ceeeea6
Revamp unsquash_dim:
ValerianRey 6ab6b4c
Add possibility to unsquash physical dimensions in view.
ValerianRey b746af8
Fix get_groupings and add test that failed before this fix
ValerianRey 59d1f2c
Fix dim encoding in transpose_int
ValerianRey 4c48523
Name more variables in __torch_dispatch__
ValerianRey 123ac3c
Remove todos in view_default
ValerianRey 469ddb3
Add support for shape inference in view_default
ValerianRey bd3e569
Add _unsafe_view_default
ValerianRey 42462bc
Add threshold_backward_default
ValerianRey 19e049d
Add sum_dim_IntList
ValerianRey 519d11b
Add broadcast_tensors_default
ValerianRey 64d0ae8
Fix mul_Tensor
ValerianRey 47f32f8
Add missing default value for keepdim in sum_dim_IntList
ValerianRey b4eb021
Improve print when falling back to dense
ValerianRey 909bcb7
Add mul_Scalar
ValerianRey c72f99e
Fix mul_Tensor to be able to handle non-tensor input
ValerianRey 4b3593b
Make test_einsum parametrizable
ValerianRey 2052d81
Add failing example to test_einsum
ValerianRey a1ccad5
Add even simpler failing example in test_einsum
ValerianRey 2675d8e
Add assertion about result being DST in test_einsum
ValerianRey 3121b6a
Add a test to get_groupings. May want to add the same to `test_fix_un…
PierreQuinton 048a1e2
Merge remote-tracking branch 'origin/block-diagonal-tensor' into bloc…
PierreQuinton 5a2a7a0
Add `strides_from_p_dims_and_p_shape`
PierreQuinton 4b83644
Add `merge_strides`
PierreQuinton 7e8439a
Add `stride_to_shape`
PierreQuinton c7047e1
Add `to_target_physical_strides`
PierreQuinton c6e3fd9
Add new_implementation idea in einsum.
PierreQuinton cecd69b
Merge branch 'dev-new-engine' into block-diagonal-tensor
ValerianRey d2e53a3
Always use randn_ in test
ValerianRey 16e7c1c
Fix order of sorting in merg_strides
PierreQuinton 2c23dbe
Merge remote-tracking branch 'origin/block-diagonal-tensor' into bloc…
PierreQuinton 16e6165
Add strides_v2
ValerianRey 59cf10b
Add more failing parametrizations to test_get_groupings and test_fix_…
ValerianRey e0dc1a7
Add test_concatenate
ValerianRey 3dffd1e
Add strides_to_pdims
ValerianRey 48387ab
Add (passing) test_to_dense2 to test to_dense when the tensor has a v…
ValerianRey f87ecbb
Use new strides in to_dense
ValerianRey b883f20
Simplify to_dense
ValerianRey 7044e37
Remove unused variable dims in the loop of to_dense
ValerianRey 384d550
Pre-compute strides
ValerianRey 18044dd
Replace for-loop with for comprehension to create v_indices_grid, and…
ValerianRey b0a0e7a
Remove for-loop in computation of v_indices_grid in to_dense
ValerianRey 456adf1
Add internal strides to debug_info
ValerianRey dc37d29
Simplify creation of strides in to_dense
ValerianRey a9e298a
Remove torch. prefix when possible
ValerianRey ac2a2c5
Create strides tensor in constructor
ValerianRey cfba7e0
Remove comments about the device of the indices tensors. We actually …
ValerianRey 2c94488
Replace self.physical.device and self.physical.dtype by self.device a…
ValerianRey 9c1ad5b
Move unwrap_to_dense out of DiagonalSparseTensor
ValerianRey 7252757
Extract print_fallback
ValerianRey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.