Skip to content

Better default force convergence function #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orionarcher wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Better default force convergence function #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion torch_sim/runners.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ def convergence_fn(
"""
force_conv = ts.system_wise_max_force(state) < force_tol

if include_cell_forces:
if include_cell_forces and hasattr(state, "cell_forces"):
if (cell_forces := getattr(state, "cell_forces", None)) is None:
raise ValueError("cell_forces not found in state")
cell_forces_norm, _ = cell_forces.norm(dim=2).max(dim=1)
Expand Down
Loading