Update pylint config

Author: linuxdaemon

.github/workflows/codeql-analysis.yml

@@ -13,12 +13,12 @@ name: "CodeQL"
 
 on:
   push:
-    branches: [ main ]
+    branches: [main]
   pull_request:
     # The branches below must be a subset of the branches above
-    branches: [ main ]
+    branches: [main]
   schedule:
-    - cron: '17 23 * * 6'
+  - cron: '17 23 * * 6'
 
 jobs:
   analyze:
@@ -32,7 +32,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        language: [ 'python' ]
+        language: ['python']
         # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
         # Learn more:
         # https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed

.pylintrc

@@ -62,6 +62,13 @@ confidence=
 # --disable=W".
 disable=invalid-name,
         missing-docstring,
+        consider-using-f-string,
+        consider-using-dict-items,
+        consider-using-with,
+        consider-using-min-builtin,
+        arguments-renamed,
+        use-maxsplit-arg,
+        consider-iterating-dictionary,
         redefined-outer-name,
         unused-argument,
         broad-except,
@@ -87,7 +94,7 @@ disable=invalid-name,
 # either give multiple identifier separated by comma (,) or put this option
 # multiple time (only on the command line, not in the configuration file where
 # it should appear only once). See also the "--disable" option for examples.
-enable=
+enable=c-extension-no-member
 
 
 [REPORTS]

plugins/profiling.py

@@ -1,3 +1,4 @@
+import os
 import signal
 import sys
 import threading
@@ -122,17 +123,12 @@ def pympler_diff():
     return "Printed to console"
 
 
-try:
-    SIGUSR1 = getattr(signal, "SIGUSR1")
-except AttributeError:
-    SIGUSR1 = None
-
 # # Provide an easy way to get a threaddump, by using SIGUSR1 (only on POSIX systems)
-if SIGUSR1 is not None:
+if os.name == "posix":
     # The handler is called with two arguments: the signal number and the current stack frame
     # These parameters should NOT be removed
     # noinspection PyUnusedLocal
     def debug(sig, frame):
         print(get_thread_dump())
 
-    signal.signal(SIGUSR1, debug)  # Register handler
+    signal.signal(signal.SIGUSR1, debug)  # Register handler

plugins/tvdb.py

@@ -209,7 +209,7 @@ class Holder(Generic[T]):
     """
 
     def __init__(self) -> None:
-        self._item: Optional[T] = None
+        self._item = None  # type: Optional[T]
         self._set = False
 
     def set(self, item: T) -> None:

tests/conftest.py

@@ -92,6 +92,7 @@ def mock_api_keys():
     mock_bot = MagicMock()
     try:
         bot.set(mock_bot)
+        # pylint: disable=no-member
         mock_bot.config.get_api_key.return_value = "APIKEY"
         yield mock_bot
     finally:

tests/core_tests/irc_client_test.py

@@ -6,8 +6,8 @@
 
 import pytest
 
-import cloudbot.clients.irc as irc
 from cloudbot.client import ClientConnectError
+from cloudbot.clients import irc
 from cloudbot.event import Event, EventType
 from cloudbot.util import async_util
 from tests.util.async_mock import AsyncMock