Conversation
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
============================================
- Coverage 72.52% 72.11% -0.41%
- Complexity 592 601 +9
============================================
Files 142 145 +3
Lines 1889 1944 +55
Branches 121 127 +6
============================================
+ Hits 1370 1402 +32
- Misses 462 485 +23
Partials 57 57
Continue to review full report at Codecov.
|
SpOOnman
left a comment
There was a problem hiding this comment.
Thank you for your PR! I have a few suggestions on this, please read them and tell me what you think.
src/main/java/pl/touk/sputnik/connector/ConnectorFacadeFactory.java
Outdated
Show resolved
Hide resolved
src/test/java/pl/touk/sputnik/connector/local/LocalFacadeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/pl/touk/sputnik/connector/local/LocalFacadeTest.java
Outdated
Show resolved
Hide resolved
src/test/java/pl/touk/sputnik/connector/local/LocalFacadeTest.java
Outdated
Show resolved
Hide resolved
|
I'm actually just realized that this patch doesn't actually work right. I'm using jgit wrong. It does the check on the uncommitted changes (since it does a git diff) whereas I need to do the equivalent of a git show. Will push a fix. |
Runs analysis tools on the HEAD of the local git repository and reports to the log. Allows someone to check for any comments before pushing to Gerrit/Gitlab.
|
Thank you for your submission! I'm sorry I was unavailable for so long. Great job! 👍 |
Add local connector type. Runs analysis tools on the HEAD of the local git repository and reports to the log. Fixes TouK#195
Fixes #195
Runs analysis tools on the HEAD of the local git repository and reports
to the log.
Allows someone to check for any comments before pushing to
Gerrit/Gitlab.