P2: fix: downgrade isomorphic-unfetch to 4.0.0
#104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch people were experiencing problems when bundling the SDK. See issue ToucanProtocol#95 ToucanProtocol#95 The problem is that `isomorphic-unfetch` 4.0.2 upgraded to `unfetch` 5.0.0 which currently has an issue with their module exports leading to an error when bundling the lib itself or any other lib that depends on `unfetch`. See this PR for more information: developit/unfetch#164 Once the PR above is merged we can go back to the latest `isomorphic-unfetch` version.
pheuberger
force-pushed
the
downgrade-isomorphic-unfetch
branch
from
b668a1d to
6c8c6a0
Compare
0xmichalis
approved these changes
Nov 30, 2023
toucan-robot
changed the title
isomorphic-unfetch to 4.0.0isomorphic-unfetch to 4.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch people were experiencing problems when bundling the SDK. See issue #95 #95
The problem is that
isomorphic-unfetch4.0.2 upgraded tounfetch5.0.0 which currently has an issue with their module exports leading to an error when bundling the lib itself or any other lib that depends onunfetch.See this PR for more information: developit/unfetch#164
Once this PR is merged we can go back to the latest
isomorphic-unfetchversion.This PR addresses issue #95