feat(python): support eager argument in load_sheet#385
feat(python): support eager argument in load_sheet#385lukapeschke merged 14 commits intoToucanToco:mainfrom
eager argument in load_sheet#385Conversation
|
Need this PR to be merged first: pola-rs/polars#24411 EDIT: No longer relevant since we are not removing functions from the API |
lukapeschke
left a comment
lukapeschke
left a comment
There was a problem hiding this comment.
Supporting the eager argument on load_sheet is a great idea, but please do not delete existing functions from the API
|
@lukapeschke now it should be okay |
lukapeschke
left a comment
lukapeschke
left a comment
There was a problem hiding this comment.
One last nit and we're good to go :) Thanks!
lukapeschke
changed the title
load_sheet and load_sheet_eager functions into oneeager argument in load_sheet
|
if else branch is required since the returned Will simplify the code in a future PR. |
arnabanimesh
force-pushed
the
patch-1
branch
from
1f19684 to
744bfd6
Compare
|
@lukapeschke Removing if else branch is not possible since we are using |
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
lukapeschke
left a comment
lukapeschke
left a comment
There was a problem hiding this comment.
@arnabanimesh I removed the if/else branch and updated the typing. Thanks again for your contribution 🙂
2 participants
No description provided.