refactor: Remove load_sheet_by_name and load_sheet_by_idx functions#387
Closed
arnabanimesh wants to merge 1 commit intoToucanToco:mainfrom
Closed
refactor: Remove load_sheet_by_name and load_sheet_by_idx functions#387arnabanimesh wants to merge 1 commit intoToucanToco:mainfrom
load_sheet_by_name and load_sheet_by_idx functions#387arnabanimesh wants to merge 1 commit intoToucanToco:mainfrom
Conversation
arnabanimesh
changed the title
load_sheet_by_name and load_sheet_by_idx functionsload_sheet_by_name and load_sheet_by_idx functions
Collaborator
|
Sorry, but we try to avoid breaking API changes as much as possible. We might deprecate those in v1.0.0, but we should not remove functions that are used by our end users |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
load_sheetfunction can operate with both indices and names (and has been documented accordingly), separate functions likeload_sheet_by_nameandload_sheet_by_idxare kind of redundant.There should be only one way of doing a particular thing in my opinion.