🛡️ Sentinel: Fix JavaScript Injection in DomMixin#37
🛡️ Sentinel: Fix JavaScript Injection in DomMixin#37ToufiqQureshi wants to merge 1 commit intomainfrom
Conversation
- Sanitize CSS selectors in `DomMixin` using `json.dumps()` to prevent breakout from JS template literals. - Add regression tests in `tests/test_security_fixes.py`. - Ensure secure handling of selector-based JS fallback logic. Co-authored-by: ToufiqQureshi <139612256+ToufiqQureshi@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
🚨 Severity: HIGH
💡 Vulnerability: CSS selectors were directly interpolated into JavaScript template literals (backticks) in the
DomMixinJS fallback logic. An attacker providing a malicious selector containing a backtick could break out of the string literal and execute arbitrary JavaScript code within the browser context.🎯 Impact: Potential for Cross-Site Scripting (XSS) or arbitrary code execution in the browser context if selectors originate from untrusted sources.
🔧 Fix: Used
json.dumps()to sanitize and quote CSS selectors before they are injected into the JavaScript code inchuscraper/core/tabs/dom.py.✅ Verification: Verified the fix with a reproduction script and added a permanent regression test in
tests/test_security_fixes.pywhich passes successfully.PR created automatically by Jules for task 17746384362930556216 started by @ToufiqQureshi