🛡️ Sentinel: [HIGH] Fix CSS selector injection in DomMixin#41
🛡️ Sentinel: [HIGH] Fix CSS selector injection in DomMixin#41ToufiqQureshi wants to merge 1 commit intomainfrom
Conversation
- Use json.dumps() to escape selectors in JS templates to prevent injection. - Cast idx to int() for additional hardening. - Add security learning to Sentinel Journal. Co-authored-by: ToufiqQureshi <139612256+ToufiqQureshi@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
🚨 Severity: HIGH
💡 Vulnerability: JavaScript injection in
DomMixin.query_selectorandquery_selector_all.🎯 Impact: Malicious CSS selectors could break out of JS template literals and execute arbitrary JavaScript in the browser context via CDP.
🔧 Fix: Used
json.dumps()to properly escape and quote CSS selectors for JavaScript templates. Addedint()cast for index variables.✅ Verification: Conceptual verification with reproduction scripts confirmed that
json.dumps()prevents template breakout.PR created automatically by Jules for task 17828127951614044148 started by @ToufiqQureshi