Skip to content

Fix issue on graceful shutdown with rabbitmq due to not copying memory for the message body #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TraGicCode merged 1 commit into from
Dec 18, 2025
Merged

Fix issue on graceful shutdown with rabbitmq due to not copying memory for the message body #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/BuslyCLI.Console/Commands/Command/SendCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ await rawEndpoint.Dispatch(
new TransportTransaction()
);

// TODO: Figure out why this causes connection closed errors with rabbitmq
// await rawEndpoint.ShutDownAndCleanUp();
await rawEndpoint.ShutDownAndCleanUp();

return 0;
}
Expand Down
3 changes: 1 addition & 2 deletions src/BuslyCLI.Console/Commands/Event/PublishCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ await rawEndpoint.Dispatch(
new TransportTransaction()
);

// TODO: Figure out why this causes connection closed errors with rabbitmq
// await rawEndpoint.ShutDownAndCleanUp();
await rawEndpoint.ShutDownAndCleanUp();

return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion src/BuslyCLI.Console/Factories/RawEndpoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ await _subscriptionManager.SubscribeAll([new MessageMetadata(CreateTypeFromStrin
public Task OnMessage(MessageContext messageContext, CancellationToken cancellationToken)
{
_receivedMessages.Add(
new IncomingMessage(messageContext.NativeMessageId, messageContext.Headers, messageContext.Body),
new IncomingMessage(messageContext.NativeMessageId, messageContext.Headers, messageContext.Body.ToArray()),
cancellationToken);
return Task.CompletedTask;
}
Expand Down