-
Notifications
You must be signed in to change notification settings - Fork 205
Feature/per commit benchmarks #1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
feliciien
wants to merge
34
commits into
TraceMachina:main
from
feliciien:feature/per-commit-benchmarks
Closed
Feature/per commit benchmarks #1711
feliciien
wants to merge
34
commits into
TraceMachina:main
from
feliciien:feature/per-commit-benchmarks
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
diouf seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
- Implement GitHub Actions workflow for automated benchmarking - Add dashboard for visualizing build times across commits - Include Slack notifications for regressions - Inspired by Lucene Nightly Benchmarks architecture
| return jsonify(projects) | ||
|
|
||
| if __name__ == '__main__': | ||
| app.run(debug=True, host='0.0.0.0') No newline at end of file |
Check failure
Code scanning / CodeQL
Flask app is run in debug mode High test
A Flask app appears to be run in debug mode. This may allow an attacker to run arbitrary code through the debugger.
Introduce a suite of scripts to automate benchmarking, result storage, regression detection, and report generation for NativeLink. This includes: - `run_benchmarks.sh`: Orchestrates benchmarking across multiple commits. - `benchmark_runner.py`: Executes benchmarks for specific configurations. - `db_uploader.py`: Uploads benchmark results to MongoDB. - `regression_detector.py`: Detects performance regressions. - `report_generator.py`: Generates visual and HTML reports from benchmark data. These tools enable continuous performance monitoring and regression detection for NativeLink.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a per-commit benchmarking system for NativeLink inspired by the Lucene Nightly Benchmarks project.
Features:
Fixes #1700
Type of change
How Has This Been Tested?
The benchmarking system has been tested locally with the following configuration:
Checklist
bazel test //...passes locally/claim #1700
This change is