Skip to content

Conversation

@palfrey
Copy link
Member

@palfrey palfrey commented Jul 3, 2025

Description

It was removed, but now appears to be unbroken again (see for example DeterminateSystems/magic-nix-cache-action#132). It's not entirely clear, but as far as I can tell the problems are apparently resolved?

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Github :)

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@palfrey palfrey marked this pull request as ready for review July 3, 2025 11:27
@MarcusSorealheis
Copy link
Collaborator

I have reservation on relying on ir but this would be great.

Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Still seems stable.

@palfrey palfrey force-pushed the readd-magic-cache branch from 634b044 to bb1a705 Compare July 16, 2025 13:00
@palfrey palfrey merged commit 8d9470b into TraceMachina:main Jul 17, 2025
36 checks passed
@palfrey palfrey deleted the readd-magic-cache branch July 17, 2025 08:35
MarcusSorealheis pushed a commit to MarcusSorealheis/nativelink that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants