Prevent retry loop large uploads#2195
Merged
MarcusSorealheis merged 4 commits intomainfrom Mar 2, 2026
Merged
Conversation
Tests the conditional that converts NotFound errors containing "not found in either fast or slow store" to FailedPrecondition, and verifies other NotFound errors still return InternalError. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The GrpcStore rpc_timeout_s defaulted to 120 seconds, which is too short for multi-GB uploads. This caused DeadlineExceeded errors that triggered retries, restarting the upload and compounding the problem. Dead connections are already detected by HTTP/2 keepalive (30s ping, 20s timeout) and TCP keepalive (30s) on each endpoint, so the per-RPC total timeout is unnecessary for that purpose. Setting rpc_timeout_s=0 now correctly disables the timeout instead of silently falling through to the 120s default. Fixes #2185
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
palfrey
approved these changes
Mar 2, 2026
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Large artifacts time out due to rpc timeout defaults being
120.Fixes #2185
Type of change
not work as expected)
How Has This Been Tested?
Unit tests
Checklist
bazel test //...passes locallygit amendsee some docsThis change is