Conversation
…I and improve user ID retrieval
Contributor
|
✅ All jobs passed Summary: 3 successful workflows
Last updated: 2025-10-28 02:31:28 UTC |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 16 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="packages/tracecat-registry/tracecat_registry/templates/tools/microsoft_entra/users/list_users.yml">
<violation number="1" location="packages/tracecat-registry/tracecat_registry/templates/tools/microsoft_entra/users/list_users.yml:115">
When $count=true is requested, Microsoft Graph requires the ConsistencyLevel header, but this line only adds it for $search or manual consistency toggles. Please include the count flag in this condition so $count calls don't fail.</violation>
</file>
<file name="packages/tracecat-registry/tracecat_registry/integrations/microsoft_entra.py">
<violation number="1" location="packages/tracecat-registry/tracecat_registry/integrations/microsoft_entra.py:42">
The user-provided email is inserted into the OData filter without escaping embedded quotes, so addresses like o'brien@example.com generate invalid queries and the Graph request fails. Escape single quotes by doubling them before interpolating.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
...ges/tracecat-registry/tracecat_registry/templates/tools/microsoft_entra/users/list_users.yml
Outdated
Show resolved
Hide resolved
packages/tracecat-registry/tracecat_registry/integrations/microsoft_entra.py
Outdated
Show resolved
Hide resolved
…osoft_entra.py Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Signed-off-by: Chris Lo <46541035+topher-lo@users.noreply.github.com>
…icrosoft_entra/users/list_users.yml Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Signed-off-by: Chris Lo <46541035+topher-lo@users.noreply.github.com>
….script.run_python and change args to inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add Microsoft Entra ID integrations with new user and group management tools built on Microsoft Graph v1.0. Also update “Get user ID by email” to use v1.0 and search both mail and userPrincipalName.
New Features
Migration