-
Notifications
You must be signed in to change notification settings - Fork 329
feat(agent): Add in-process MCP support #1946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1a3f10f to
f73368e
Compare
|
@cubic review |
|
@codex review |
@jordan-umusu I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 21 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="frontend/src/components/integrations/mcp-integration-dialog.tsx">
<violation number="1" location="frontend/src/components/integrations/mcp-integration-dialog.tsx:337">
P2: Guard command_env parsing by server_type. As written, JSON.parse runs even for URL-type integrations, so stale/invalid command_env input can throw and block submit after switching server type.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
frontend/src/components/integrations/mcp-integration-dialog.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f73368e620
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
frontend/src/app/workspaces/[workspaceId]/integrations/mcp/[mcpIntegrationId]/page.tsx
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 21 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="frontend/src/components/integrations/mcp-integration-dialog.tsx">
<violation number="1" location="frontend/src/components/integrations/mcp-integration-dialog.tsx:197">
P2: Command env validation allows non-string values, but the API expects `Record<string, string>`. Validate that all values are strings before accepting the JSON.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
frontend/src/components/integrations/mcp-integration-dialog.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08b85f3662
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
a9283f9 to
761bd70
Compare
761bd70 to
a9268b0
Compare
Summary by cubic
Adds in-process MCP support so agents can run command-based MCP servers (stdio) inside the sandbox. Extends MCP integrations, presets, runtime, and UI to configure, validate, and run these servers securely.
New Features
Migration
Written for commit a9268b0. Summary will update on new commits.