-
Notifications
You must be signed in to change notification settings - Fork 329
feat(rbac): Add database schema for RBAC tables #1983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d122f2e to
1b9c4aa
Compare
This comment has been minimized.
This comment has been minimized.
1b9c4aa to
b1dac5d
Compare
|
@cubic review |
@jordan-umusu I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 5 files
c1e6b3e to
7a37727
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a37727f59
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 5 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="alembic/versions/8b630b0a094e_add_rbac_tables.py">
<violation number="1" location="alembic/versions/8b630b0a094e_add_rbac_tables.py:285">
P1: Partial unique index is missing `organization_id`, which would prevent users from having org-level role assignments in multiple organizations. The index should be on `["user_id", "organization_id"]` to allow one org-level assignment per user per organization.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
7a37727 to
bf77ee8
Compare
bf77ee8 to
85da236
Compare
85da236 to
a4f7e61
Compare
a4f7e61 to
18c1c93
Compare
|
Found 1 test failure on Blacksmith runners: Failure
|
3826d59 to
8beaba2
Compare

Summary by cubic
Introduces the RBAC database schema with scopes, roles, groups, and assignments to support org- and workspace-level permissions. Adds the "viewer" workspace role and aligns backend enums and frontend types.
New Features
Migration
Written for commit 7a37727. Summary will update on new commits.