Skip to content

Conversation

@daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Feb 9, 2026

Summary

  • Add 118 new tests covering critical coverage gaps across the codebase
  • Executor service (44 tests): expression evaluation, for_each dispatch, context materialization, secret masking, registry artifacts
  • Validation service (28 tests): entrypoint/expression/action validation, multi-tier pipeline
  • API routers (31 tests): workflow executions, organization, webhooks
  • Temporal failures (6 tests): cancellation, termination, retry exhaustion, scatter-gather failure
  • Tables service (9 tests): search, pagination, exists query
  • Update conftest fixtures with proper manifest schema and auth dependency overrides

Test plan

  • All 118 new tests pass
  • Full unit test suite (3052 tests) passes with no regressions
  • Temporal tests (6) pass
  • Ruff lint/format clean
  • Pyright 0 errors, 0 warnings

Summary by cubic

Adds 118 tests across executor, validation, API routers, tables, and Temporal failure paths. Improves coverage of critical workflows and failure modes, with fixtures updated for manifest and auth expectations.

  • Coverage

    • Executor and validation (72): expression eval, for_each dispatch, context/secret handling, registry artifacts; entrypoint/action/expression validation.
    • API routers (31): workflow executions, organization, and webhooks (HTTP-level).
    • Temporal failures (6): retry exhaustion, cancellation, termination, scatter partial failure.
    • Tables (9): search, cursor pagination, exists queries, column type validation.
  • Test Infrastructure

    • Added workflow definitions for retry exhaustion and scatter partial failure.
    • Updated conftest with core.transform.reshape manifest schema and API auth role overrides.

Written for commit 47df467. Summary will update on new commits.

…ailures

Add 118 new tests across critical coverage gaps:

- Executor service (44 tests): expression evaluation, for_each dispatch,
  context materialization, secret masking, registry artifacts
- Validation service (28 tests): entrypoint validation, expression
  validation, action arg validation, multi-tier pipeline
- API routers (31 tests): workflow executions, organization, webhooks
- Temporal failures (6 tests): cancellation, termination, retry
  exhaustion, scatter-gather failure, expression errors
- Tables service expansion (9 tests): search, pagination, exists query

Update conftest fixtures with proper core.transform.reshape manifest
schema and API router auth dependency overrides.
@daryllimyt daryllimyt added the tests Changes to unit and integration tests label Feb 9, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Changes to unit and integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants