fix(agents): drop parallel_tool_calls param for custom model providers#2455
Merged
daryllimyt merged 1 commit intomainfrom Apr 2, 2026
Merged
fix(agents): drop parallel_tool_calls param for custom model providers#2455daryllimyt merged 1 commit intomainfrom
daryllimyt merged 1 commit intomainfrom
Conversation
jordan-umusu
temporarily deployed
to
internal-registry-ci
GitHub Actions
Inactive
jordan-umusu
temporarily deployed
to
internal-registry-ci
GitHub Actions
Inactive
jordan-umusu
requested review from
daryllimyt and
topher-lo
and removed request for
topher-lo
|
✅ No security or compliance issues detected. Reviewed everything up to a4f2fe3. Security Overview
Detected Code Changes
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4f2fe3253
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Remove
parallel_tool_callsfrom custom model provider payloads to stop malformedtool_choicegeneration byLiteLLMwhen routing toBedrock. This aligns with the OpenAI spec and prevents tool-calling errors for non-OpenAI providers.parallel_tool_callsduring custom provider normalization, fixing missingtypein downstreamtool_choice. OpenAI model payloads are unchanged.Written for commit a4f2fe3. Summary will update on new commits.