fix(schedule): preserve workspace search attrs on update#2459
Open
daryllimyt wants to merge 1 commit intomainfrom
Open
fix(schedule): preserve workspace search attrs on update#2459daryllimyt wants to merge 1 commit intomainfrom
daryllimyt wants to merge 1 commit intomainfrom
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to ee9acb6. Security Overview
Detected Code Changes
|
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_scheduleTesting
uv run ruff check tracecat/workflow/schedules/bridge.py tracecat/workflow/schedules/service.py tests/unit/test_schedule_update_search_attributes.pyuv run pyright tracecat/workflow/schedules/bridge.py tracecat/workflow/schedules/service.py tests/unit/test_schedule_update_search_attributes.pyTRACECAT__SERVICE_KEY=dummy uv run pytest tests/unit/test_schedule_update_search_attributes.pySummary by cubic
Preserves workspace-scoped Temporal search attributes when updating schedules. Prevents
WORKSPACE_IDloss so schedule queries and filters continue to work after updates.Roleintoupdate_scheduleand rebuild search attributes with the provided role; otherwise use the decoded role, and finallytracecat-schedule-runneras a fallback.WORKSPACE_ID,TRIGGER_TYPE,EXECUTION_TYPE, and paused state when setting status to offline.Written for commit ee9acb6. Summary will update on new commits.