fix: MCP instruction expression brace syntax#2461
Merged
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to 17460cd. Security Overview
Detected Code Changes
|
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
${{ ... }}expression syntax, but the instruction string was an f-string which unescaped doubled braces and caused examples to appear as${ ... }, so the instructions were misleading.Description
fprefix from the_MCP_INSTRUCTIONSstring intracecat/mcp/server.pyso literal${{ ... }}placeholders are preserved in the server-provided instructions.Testing
uv run ruff check tracecat/mcp/server.pyand it completed successfully.Codex Task
Summary by cubic
Fix MCP server instructions so
${{ ... }}placeholders render correctly for clients. Also removes a redundant unit test tied to specific instruction text._MCP_INSTRUCTIONSto a plain triple-quoted string intracecat/mcp/server.pyto preserve literal${{ ... }}.tests/unit/test_mcp_server.py.Written for commit 17460cd. Summary will update on new commits.