Refines config loading and message defaults

mbertelsen · mbertelsen · commit f1a8241439f0 · 2025-09-23T11:00:54.000-04:00
Omits runtime config injection during local development and warns if unavailable
Provides default message for safer editing
Loosens schema constraints to allow indefinite message display
diff --git a/editor/index.html b/editor/index.html
@@ -8,10 +8,15 @@
     <link rel="stylesheet" href="/src/index.css" />
     <!-- Runtime configuration for Azure App Service -->  
     <script>
-      // Load runtime config with cache-busting timestamp
-      const script = document.createElement('script');
-      script.src = '/runtime-config.js?v=' + Date.now();
-      document.head.appendChild(script);
+      // Load runtime config with cache-busting timestamp (only in production)
+      if (window.location.hostname !== 'localhost' && window.location.hostname !== '127.0.0.1') {
+        const script = document.createElement('script');
+        script.src = '/runtime-config.js?v=' + Date.now();
+        script.onerror = function() {
+          console.warn('Runtime config not available - using build-time environment variables');
+        };
+        document.head.appendChild(script);
+      }
     </script>
   </head>
   <body>
diff --git a/editor/src/components/MessageEditor.tsx b/editor/src/components/MessageEditor.tsx
@@ -3,13 +3,16 @@ import { Message } from '../types';
 
 interface MessageEditorProps {
   title: string;
-  message: Message;
+  message: Message | undefined;
   onChange: (message: Message) => void;
 }
 
 export const MessageEditor: React.FC<MessageEditorProps> = ({ title, message, onChange }) => {
+  // Provide default empty message if undefined
+  const currentMessage: Message = message || { header: '', description: '', seconds: -1 };
+  
   const update = (patch: Partial<Message>) => {
-    onChange({ ...message, ...patch });
+    onChange({ ...currentMessage, ...patch });
   };
 
   return (
@@ -21,7 +24,7 @@ export const MessageEditor: React.FC<MessageEditorProps> = ({ title, message, on
           Header
           <input 
             type="text" 
-            value={message.header} 
+            value={currentMessage.header} 
             onChange={e => update({ header: e.target.value })}
             placeholder="Enter message header..."
           />
@@ -33,7 +36,7 @@ export const MessageEditor: React.FC<MessageEditorProps> = ({ title, message, on
           Description
           <input 
             type="text" 
-            value={message.description || ''} 
+            value={currentMessage.description || ''} 
             onChange={e => update({ description: e.target.value })}
             placeholder="Optional supporting text..."
           />
@@ -45,7 +48,7 @@ export const MessageEditor: React.FC<MessageEditorProps> = ({ title, message, on
           Display Duration
           <select 
             className="cond-input"
-            value={message.seconds || 0} 
+            value={currentMessage.seconds || 0} 
             onChange={e => update({ seconds: Number(e.target.value) })}
           >
             <option value={0}>Hidden</option>
diff --git a/editor/src/components/TreeView.tsx b/editor/src/components/TreeView.tsx
@@ -2,7 +2,8 @@ import React from 'react';
 import { ScriptData, Activity, Step } from '../types';
 
 // Convert PascalCase to readable title (e.g., "RangeAnalysisScriptedStep" -> "Range Analysis Scripted Step")
-const formatNodeType = (nodeType: string): string => {
+const formatNodeType = (nodeType: string | undefined): string => {
+  if (!nodeType) return 'Unknown Type';
   return nodeType
     .replace(/([A-Z])/g, ' $1') // Add space before capital letters
     .trim(); // Remove leading space
diff --git a/editor/src/factories.ts b/editor/src/factories.ts
@@ -10,9 +10,53 @@ export function createMessage(partial: Partial<Message> = {}): Message {
 }
 
 export function createActivity(opts: any): ScriptedActivity {
-  return opts as ScriptedActivity;
+  const activity = {
+    nodeType: opts.nodeType || 'RangeAnalysisScriptedActivity',
+    id: opts.id,
+    introMessage: opts.introMessage || {
+      header: opts.introHeader || '',
+      description: opts.introDescription || '',
+      seconds: -1
+    },
+    endMessage: opts.endMessage || {
+      header: '',
+      description: '',
+      seconds: -1
+    },
+    steps: opts.steps || []
+  };
+  
+  return activity as ScriptedActivity;
 }
 
 export function createStep(opts: any): ScriptedStep {
-  return opts as ScriptedStep;
+  const step = {
+    nodeType: opts.nodeType || 'RangeAnalysisScriptedStep',
+    id: opts.id,
+    introMessage: opts.introMessage || {
+      header: opts.introHeader || '',
+      description: opts.introDescription || '',
+      seconds: -1
+    },
+    successMessage: opts.successMessage || {
+      header: '',
+      description: '',
+      seconds: -1
+    },
+    failMessage: opts.failMessage || {
+      header: '',
+      description: '',
+      seconds: -1
+    },
+    logic: opts.logic || {
+      // Default logic based on step type
+      ...(opts.nodeType === 'PerformanceCenterScriptedStep' ? {
+        nodeType: 'PerformanceCenterScriptedLogic'
+      } : {
+        nodeType: 'RangeAnalysisScriptedLogic'
+      })
+    }
+  };
+  
+  return step as ScriptedStep;
 }
diff --git a/editor/src/schema/app-scripting.schema.json b/editor/src/schema/app-scripting.schema.json
@@ -77,7 +77,6 @@
       "properties": {
         "header": {
           "type": "string",
-          "minLength": 1,
           "description": "Primary message header text displayed to the user."
         },
         "description": {
@@ -87,7 +86,7 @@
         },
         "seconds": {
           "type": "integer",
-          "minimum": 0,
+          "minimum": -1,
           "default": 3,
           "description": "Seconds to display message on screen. Use -1 to require user to click button to dismiss message."
         }
diff --git a/schema/1.0.0/app-scripting.schema.json b/schema/1.0.0/app-scripting.schema.json
@@ -77,7 +77,6 @@
       "properties": {
         "header": {
           "type": "string",
-          "minLength": 1,
           "description": "Primary message header text displayed to the user."
         },
         "description": {
@@ -87,7 +86,7 @@
         },
         "seconds": {
           "type": "integer",
-          "minimum": 0,
+          "minimum": -1,
           "default": 3,
           "description": "Seconds to display message on screen. Use -1 to require user to click button to dismiss message."
         }
