Skip to content

Conversation

@h1treX
Copy link
Contributor

@h1treX h1treX commented Dec 1, 2025

draft pr for changes discussed in #351

@wittighausen
Copy link
Collaborator

I would like this to be implemented as well, but I’m not sure if it’s a good idea to rename backgroundColor and textColor, because I think almost every project using this data refers to these column names, which would become invalid if they were renamed.

Maybe an explanation in the README on how to use the color columns for the text shape would be a more suitable idea?

@h1treX
Copy link
Contributor Author

h1treX commented Dec 22, 2025

I thought this would be more consistent as it would not mean the backgroundColor would become the textColor which might be quite confusing as well. But I'm not sure which is the best option here. Maybe I'll come around to change it back in the next few days

@wittighausen
Copy link
Collaborator

I mean, if you think further into it, then the backgroundColor will actually become the background color of the shape, in this case of the new text shape, which is technically the same as the rectangle or the pill, but these are just my deeper thoughts on this topic, which are a bit overcomplicated lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants