Merged
Conversation
グレース期間中にnearestStationが変わった場合でもisArrivedがtrueを返していたため、 到着直後にGPSのぶれで次の駅に誤って進む問題が発生していた。 グレース期間の適用を到着を引き起こした駅に限定し、useNearestStationで currentStationをnextStationより優先するように変更。 https://claude.ai/code/session_0125DF6zeKaFmYsCqKciDTog
Contributor
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthrough複数の駅が同じ座標を共有する場合の最寄り駅の選択順序を変更します。また、到着イベントを追跡するための Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
グレース期間中にnearestStationが変わった場合でもisArrivedがtrueを返していたため、
到着直後にGPSのぶれで次の駅に誤って進む問題が発生していた。
グレース期間の適用を到着を引き起こした駅に限定し、useNearestStationで
currentStationをnextStationより優先するように変更。
https://claude.ai/code/session_0125DF6zeKaFmYsCqKciDTog
Summary by CodeRabbit
リリースノート