Skip to content

E235系風ヘッダーの行き先表示2行化#5370

Merged
TinyKitten merged 2 commits intodevfrom
feature/e235-multiline
Feb 20, 2026
Merged

E235系風ヘッダーの行き先表示2行化#5370
TinyKitten merged 2 commits intodevfrom
feature/e235-multiline

Conversation

@TinyKitten
Copy link
Copy Markdown
Member

@TinyKitten TinyKitten commented Feb 20, 2026

Summary by CodeRabbit

リリースノート

  • バグ修正
    • ヘッダーのテキストが2行まで表示され、折り返しが改善されました(iOSでの行区切り挙動を調整)。
    • 固定高さの制約を解除し、テキスト表示領域が柔軟になりました。

@TinyKitten TinyKitten self-assigned this Feb 20, 2026
@github-actions github-actions bot added the react label Feb 20, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 20, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

HeaderE235.tsx のレイアウト制約を調整。boundContainer の高さ制約を削除し、Typography の行数を 1→2 に増やし、iOS/Android の行折り返しプロパティを追加してテキスト折り返しを改善。

Changes

Cohort / File(s) Summary
HeaderE235 更新
src/components/HeaderE235.tsx
boundContainer から height 制約(height: '50%')を削除。bound 表示に使う TypographynumberOfLines を 1→2 に変更し、lineBreakStrategyIOS="push-out"textBreakStrategy="balanced" を追加。公開 API に変更なし。

Sequence Diagram(s)

(該当せず)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

react

Poem

🐇 ふわり跳ねるバグの跡、消して
行を二つに広げて歌うよ
折り返しも丁寧に扱って
小さなヘッダー、大きな微笑み 😊
コードの畑にニンジンひとつ🍀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed プルリクエストのタイトルは「E235系風ヘッダーの行き先表示2行化」であり、変更内容の主要な目的(行き先表示を2行対応にする)を正確に反映している。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/e235-multiline

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/components/HeaderE235.tsx`:
- Line 29: The style object named "bound" inside HeaderE235 contains
justifyContent: 'center', which is a View flexbox property and has no effect on
the Typography/Text component it is applied to; remove the justifyContent entry
from the "bound" style or move it to the parent container (the View wrapping the
Typography/Text) so centering is performed on a View (e.g., adjust the parent
container style instead of the Typography/Text in HeaderE235).

@TinyKitten TinyKitten merged commit bdb5c34 into dev Feb 20, 2026
6 checks passed
@TinyKitten TinyKitten deleted the feature/e235-multiline branch February 20, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant