Skip to content

hermes v1無効化#5488

Merged
TinyKitten merged 1 commit intodevfrom
chore/optout-hermes
Feb 27, 2026
Merged

hermes v1無効化#5488
TinyKitten merged 1 commit intodevfrom
chore/optout-hermes

Conversation

@TinyKitten
Copy link
Member

@TinyKitten TinyKitten commented Feb 27, 2026

Androidのビルドが遅くて現状割に合わない

Summary by CodeRabbit

Chores

  • ビルド設定の最適化: アプリケーションの設定ファイルを整理し、プラグイン設定と関連する依存関係を削除しました。
  • 依存関係の整理: 不要なパッケージを削除し、プロジェクト構成を簡素化しました。

@TinyKitten TinyKitten self-assigned this Feb 27, 2026
@github-actions github-actions bot added the ios label Feb 27, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d68fd82 and ee9d776.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • app.config.ts
  • ios/Podfile.properties.json
  • package.json
💤 Files with no reviewable changes (1)
  • app.config.ts

📝 Walkthrough

Walkthrough

Hermes V1 およびそれに関連するビルド設定を削除するプルリクエスト。app.config.ts から expo-build-properties プラグインを削除し、ios/Podfile.properties.json で Hermes V1 を無効化し、package.json から関連する依存関係とオーバーライドを削除。

Changes

Cohort / File(s) Summary
Hermes V1 設定の削除
app.config.ts, ios/Podfile.properties.json, package.json
expo-build-properties プラグインの削除、useHermesV1 の true から false への変更、buildReactNativeFromSource 設定の削除、hermes-compiler オーバーライドの削除。

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

ios, react

Poem

🐰 Hermes に別れを告げて
ビルド設定をシンプルに戻す
V1 の速度は不要か
設定の森から飛び出し
より軽い道を選びました 🌿

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed プルリクエストのタイトルは「hermes v1無効化」で、変更内容の主要な目的(Hermes v1の無効化)を明確かつ簡潔に要約しており、変更セットの主な内容と完全に対応しています。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/optout-hermes

Comment @coderabbitai help to get the list of available commands and usage tips.

@TinyKitten TinyKitten merged commit 5a9cd34 into dev Feb 27, 2026
7 checks passed
@TinyKitten TinyKitten deleted the chore/optout-hermes branch February 27, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant