Merged
Conversation
* phonemeタグの内側テキストをnameKatakanaのひらがな変換に変更 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * afterNextStationのph()呼び出しに不足していた第3引数nameKatakanaを追加 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * 複数行にまたがるph()の第3引数追加漏れを修正、replaceJapaneseTextのフォールバック改善 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
* TTS関連のnameRoman/nameRomanIpaをnameTtsSegmentsに置き換え Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * useCurrentTrainType.test.tsxにnameTtsSegmentsを追加してtypecheck修正 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * 連続するIPAセグメントを単一のphonemeタグに結合 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * nameTtsSegmentsがnullの場合にnameRomanへfallback、TtsSegmentFieldsフラグメント共通化 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fallbackのXMLエスケープ適用、station内nameTtsSegmentsをフラグメント参照に統一 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: TinyKitten <32848922+TinyKitten@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.