Conversation
conradarcturus
left a comment
conradarcturus
left a comment
There was a problem hiding this comment.
There appears to be a lot of good work in this change. However, I won't give a full review until you post a test plan. Please add how you tested it, how you run the new command you added, and include screenshots.
| const CLDR_CORE_BASE = `https://cdn.jsdelivr.net/npm/cldr-core@${CLDR_RELEASE}`; | ||
| const CHARTS_TSV_BASE = `https://raw.githubusercontent.com/unicode-org/cldr-staging/main/docs/charts/${CLDR_RELEASE.replace( | ||
| /\.0\.0$/, | ||
| '', | ||
| )}/tsv`; | ||
| const CLDR_REPO_RAW_BASE = 'https://raw.githubusercontent.com/unicode-org/cldr/main/common/main'; |
There was a problem hiding this comment.
I'm not certain I want to ingest the data -- what were the tradeoffs that you considered when you decided to use these URLs?
There is the CLDR Json repository that we already have access to data in. You can see how we use it in files like UnicodeData.tsx where we access the data with imports like import territoryInfo from 'cldr-core/supplemental/territoryInfo.json';
| { | ||
| "release": "0.0.0", | ||
| "generatedAt": "", | ||
| "locales": [] |
There was a problem hiding this comment.
This output file is empty -- is there supposed to be data in it?
src/types/CLDRLocaleTypes.tsx
Outdated
| script?: string; | ||
|
|
||
| /** Tier of locale support: core, modern or full */ | ||
| tier: 'core' | 'modern' | 'full'; |
There was a problem hiding this comment.
This doesn't look like the CLDR levels that I am used to. I'm used to seeing "core", "basic", "moderate", "modern". Where do these tiers come from?
wizardsimms
force-pushed
the
56-locales-add-cldr-support-per-locale
branch
from
97d60ae to
dcdab07
Compare
2 participants
Add CLDR locale support by ingesting CLDR data for locales (e.g., en_US, en_GB) and displaying coverage indicators in LocaleTable and LocaleDetails, similar to how language-level CLDR support is shown.