refactor: move DataProvider to app level with deferred loading#500
refactor: move DataProvider to app level with deferred loading#500mchen11077 wants to merge 9 commits intomasterfrom
Conversation
conradarcturus
left a comment
There was a problem hiding this comment.
1 minor change.
This is partially deferred -- but the way you set it up, you are blocking the whole page render until the 2 components have been loaded. If you have cached the page it is pretty fast, but we should return the children without providers. However we expect people to load the page with mobile devices and/or limited internet connections.
You can test out the page with limited network connections in the chrome debug tools, click the icon with the laptop/cellphone to open with mobile device specs and throttle the network connection to mid-tier or low-tier mobile.
conradarcturus
left a comment
There was a problem hiding this comment.
It looks like something may have been merged incorrectly.
Apologies if you were waiting for me for awhile for comments. Since there are so many changes I usually only check in when it says "waiting for review" (it still says "changed requested" right now, you can click a button to switch it back to "waiting for review"). Also if there are build or test errors I usually ignore it too, expecting you to fix it before I get back to the change.
Co-authored-by: Conrad Nied <conrad@translationcommons.org>
Fixes #481
Summary: Move DataProvider to App and keep it lazily loaded.
Changes
Test Plan
npm run dev/introrenders immediately/dataloads correctlynpm run buildand confirm DataProvider is a separate chunkChecklist