refactor(sidebar): simplify Options panel to Filters only#505
Draft
mchen11077 wants to merge 1 commit intomasterfrom
Draft
refactor(sidebar): simplify Options panel to Filters only#505mchen11077 wants to merge 1 commit intomasterfrom
mchen11077 wants to merge 1 commit intomasterfrom
Conversation
Collaborator
|
It's a bit premature to do this because you are removing actively used functionality where there is not a replacement. Before removing them, we need to put these controls in an alternative place. Is there an issue tracking that? If not you should file it cc @hdprajwal . For the alternative place -- we have an unused modal component that we'll want to bring back in and generalize it like we do the Hovercards -- we can move the Data & View Options into that modal. See where the gear icon is in the top left of the design. https://www.figma.com/proto/ZGJOgi5MnvtrKeaBJFrtZa/Language-Navigator?node-id=361-3&t=ae2PI8RkLX7axmzm-1&scaling=contain&content-scaling=fixed&page-id=361%3A2&starting-point-node-id=361%3A3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes