Conversation
| @@ -44,7 +34,7 @@ jobs: | |||
|
|
|||
| - uses: actions-rs/cargo@v1 | |||
There was a problem hiding this comment.
Not for this PR, but if we're going to maintain this ourselves going forward actions-rs should just be removed. It's deprecated and unmaintained for years.
src/callback.rs
Outdated
| } | ||
| // pub(crate) unsafe fn register_call_result<C, F, Manager>( | ||
| // inner: &Arc<Inner<Manager>>, | ||
| // api_call: sys::SteamAPICall_t, |
There was a problem hiding this comment.
Is this maybe still there? Might not want to comment it out if we use the file and contents compile successfully.
| let lib_name = libloading::library_filename("steam_api"); | ||
|
|
||
| let exe_path = std::env::current_exe().unwrap(); | ||
| exe_path.parent().unwrap().join(lib_name) |
There was a problem hiding this comment.
Wasn't this the default on Windows? Or did it look relative to PATH/cwd? Or all of them?
There was a problem hiding this comment.
I thought it looked next to exe on Windows but when I passed only the library_filename to libloading::Library::new(path) it didn't work. Specifying the full path to the exe did work so 🤷.
| .join("public/steam/steam_gameserver.h") | ||
| .to_string_lossy(), | ||
| ) | ||
| .allowlist_item("SteamAPI\\w+") |
There was a problem hiding this comment.
That'd be nice to upstream to get rid of spam there too :)
Co-authored-by: Marijn Suijten <marijns95@gmail.com>
Co-authored-by: Marijn Suijten <marijns95@gmail.com>
…teamworks-rs into steamworks-refactors
2 participants
This PR includes the following changes:
libloadingsteamworks-sys'sbuild.rstarget_dirinstead ofout_dirWhen reviewing, focus on the following files:
steamworks/lib.rssteamworks-sys/build.rs