Enable user_stats module for achievements and leaderboards#3
Closed
Jasper-Bekkers wants to merge 41 commits intomasterfrom
Closed
Enable user_stats module for achievements and leaderboards#3Jasper-Bekkers wants to merge 41 commits intomasterfrom
Jasper-Bekkers wants to merge 41 commits intomasterfrom
Conversation
Co-authored-by: Marijn Suijten <marijns95@gmail.com>
Co-authored-by: Marijn Suijten <marijns95@gmail.com>
…teamworks-rs into steamworks-refactors
This PR includes the following changes:
Update steamworks SDK to 1.61
Update Rust dependencies
Minor updates to CI
Moved to runtime library loading through libloading
Only ported over APIs that we require for our internal projects
Simplified steamworks-sys's build.rs
Copy steam sdk library to target_dir instead of out_dir
When reviewing, focus on the following files:
steamworks/lib.rs
steamworks-sys/build.rs
Downgrade `thiserror` to `1` Needed by internal projects.
- Uncomment user_stats module declaration and exports in lib.rs - Add user_stats() method to Client implementation - Update user_stats.rs to use dynamic library pattern (self.inner.lib.*) - Update stats.rs achievement helper to use dynamic library pattern - Add missing callback struct definitions to steamworks-sys: - UserStatsReceived_t, UserStatsStored_t, UserAchievementStored_t - UserAchievementIconFetched_t, LeaderboardFindResult_t - LeaderboardScoreUploaded_t, LeaderboardScoresDownloaded_t - GlobalAchievementPercentagesReady_t Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Jasper-Bekkers
force-pushed
the
Traverse-Research/enable-user-stats-module
branch
from
39ab702 to
021accb
Compare
Member
Author
|
Closing to recreate with correct base branch (for-traverse instead of master) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user_statsmodule which was previously commented outChanges
src/lib.rs
mod user_statsandpub use crate::user_stats::*CStringimport for string handlinguser_stats()method toClientimplementationsrc/user_stats.rs & src/user_stats/stats.rs
self.inner.lib.SteamAPI_*instead ofsys::SteamAPI_*)libArc before capturingsteamworks-sys/src/lib.rs
UserStatsReceived_t- callback for RequestCurrentStatsUserStatsStored_t- callback for StoreStatsUserAchievementStored_t- callback for achievement storageUserAchievementIconFetched_t- callback for achievement icon fetchLeaderboardFindResult_t- callback for FindLeaderboardLeaderboardScoreUploaded_t- callback for UploadLeaderboardScoreLeaderboardScoresDownloaded_t- callback for DownloadLeaderboardEntriesGlobalAchievementPercentagesReady_t- callback for RequestGlobalAchievementPercentagesFeatures Enabled
Test plan
cargo checkpasses successfully🤖 Generated with Claude Code