Add mTLS support to OIDC issuer #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds command line options that allow supplying a client certificate to be used when connecting to the OIDC issuer. The client certificate must be signed by a CA that the OIDC issuer trusts. This allows interoperability with OIDC issuers that enforce mTLS on sessions. Issue: TremoloSecurity#67 Signed-off-by: Allain Legacy <[email protected]>
|
nice update to the test suites! let me do some testing, but this looks great. |
|
Could you hold off on merging this until I’ve had an opportunity to double check something. I am using a similar technique to dynamically load the client certificate in a separate project and I’ve noticed some odd behavior that I need to look into to make sure this doesn’t have a bug in it. |
False alarm... problem was between the keyboard and the chair. No issue here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds command line options that allow supplying a client certificate to be used when connecting to the OIDC issuer. The client certificate must be signed by a CA that the OIDC issuer trusts. This allows interoperability with OIDC issuers that enforce mTLS on sessions.
Issue: #67