Skip to content

chore: migrate new tresleches #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tinoooo merged 9 commits into from
Mar 9, 2025
Merged

chore: migrate new tresleches #178

Tinoooo merged 9 commits into from
Mar 9, 2025

Conversation

@damienmontastier
Copy link
Member

@damienmontastier damienmontastier commented Jan 30, 2025 •
edited
Loading

This is a PR that modifies the old use of tres/leches (with .value.value) to the next version. It also modifies the @tresjs/leches call as a dependency in the root package.json instead of in the /playground and /docs subfolders.

I have added TODO: in some files.

Feedbacks

I have 1 problems:

  • How do I access the .visible value of a useControls element?

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 30, 2025 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/post-processing@178

commit: 36cdfb5

This was referenced Feb 6, 2025
Merged
Merged
Merged
Merged
Merged
Tinoooo
Tinoooo reviewed Mar 9, 2025
View reviewed changes
@Tinoooo Tinoooo requested review from Tinoooo and removed request for alvarosabu March 9, 2025 12:35
@Tinoooo Tinoooo merged commit efddeac into main Mar 9, 2025
4 checks passed
@Tinoooo Tinoooo deleted the chore/migrate-new-tresleches branch March 9, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tinoooo Tinoooo Tinoooo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@damienmontastier @Tinoooo @alvarosabu