fix: update canvas handling for custom renderer support#1210
Draft
Jungzl wants to merge 3 commits intoTresjs:mainfrom
Draft
fix: update canvas handling for custom renderer support#1210Jungzl wants to merge 3 commits intoTresjs:mainfrom
Jungzl wants to merge 3 commits intoTresjs:mainfrom
Conversation
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for tresjs-lab failed. Why did it fail? →
|
✅ Deploy Preview for tresjs-lab ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom renderers like mapbox-gl create their own canvas elements instead of using the provided one. This caused event listeners to attach to the wrong DOM element, breaking interactions in custom renderer scenarios.