chore: replace aws-sdk with @types/aws-sdk2-types

This is a second attempt at fixing aws#417. The first attempt was aws#425,
which simply moved `aws-sdk` from `dependencies` to `devDependencies`.
That change was reverted by aws#535.

The reason for the revert was this claim from @suprajaven:

> The package is currently not declaring a dependency but it is actually
> using aws-sdk. The overall impact is not noted because when used in
> conjunction with language servers package ( which has this dependency
> present) the overall build is not broken.

I believe this is a misunderstanding: The reason the dependency could be
safely moved to `devDependencies` is that all of the references to that
package were actually just importing types, which means they weren't
used at runtime.

Here I've gone a step further and replaced the `aws-sdk` dependency with
`@types/aws-sdk2-types`. These types were pulled directly from
`aws-sdk@2`, so they should match:
DefinitelyTyped/DefinitelyTyped#64111

This change ensures that `aws-sdk` won't be used at runtime. As a bonus,
it makes this repo's `node_modules` nearly 100MB lighter, which should
speed up builds and other development processes.

Author: TrevorBurnham

package-lock.json

@@ -52,12 +52,12 @@
         "registry-js": "^1.16.1"
     },
     "devDependencies": {
+        "@types/aws-sdk2-types": "^0.0.5",
         "@types/mocha": "^10.0.9",
         "@types/mock-fs": "^4.13.4",
         "@types/node": "^22.15.17",
         "@types/node-forge": "^1.3.11",
         "assert": "^2.0.0",
-        "aws-sdk": "^2.1692.0",
         "copyfiles": "^2.4.1",
         "husky": "^9.1.7",
         "json-schema-to-typescript": "^15.0.4",

runtimes/package.json

@@ -98,8 +98,8 @@ import {
 import { IdentityManagement } from '../server-interface/identity-management'
 import { WebBase64Encoding } from './encoding'
 import { LoggingServer } from './lsp/router/loggingServer'
-import type { Service } from 'aws-sdk'
-import { ServiceConfigurationOptions } from 'aws-sdk/lib/service'
+import { Service } from 'aws-sdk2-types'
+import { ServiceConfigurationOptions } from 'aws-sdk2-types/lib/service'
 import { getClientInitializeParamsHandlerFactory } from './util/lspCacheUtil'
 import { newAgent } from './agent'
 import { ShowSaveFileDialogRequestType, CheckDiagnosticsRequestType } from '../protocol/window'

runtimes/runtimes/base-runtime.ts

@@ -87,8 +87,8 @@ import { getServerDataDirPath } from './util/serverDataDirPath'
 import { ProxyConfigManager } from './util/standalone/experimentalProxyUtil'
 import { Encoding } from './encoding'
 import { LoggingServer } from './lsp/router/loggingServer'
-import type { Service } from 'aws-sdk'
-import { ServiceConfigurationOptions } from 'aws-sdk/lib/service'
+import { Service } from 'aws-sdk2-types'
+import { ServiceConfigurationOptions } from 'aws-sdk2-types/lib/service'
 import { getTelemetryLspServer } from './util/telemetryLspServer'
 import { getClientInitializeParamsHandlerFactory } from './util/lspCacheUtil'
 import { makeProxyConfigv2Standalone, makeProxyConfigv3Standalone } from './util/standalone/proxyUtil'

runtimes/runtimes/standalone.ts

@@ -7,7 +7,7 @@ import { readFileSync } from 'node:fs'
 import * as tls from 'node:tls'
 import { Agent as HttpsAgent } from 'node:https'
 import { X509Certificate } from 'node:crypto'
-import type { ConfigurationOptions } from 'aws-sdk'
+import { ConfigurationOptions } from 'aws-sdk2-types'
 import { HttpsProxyAgent } from 'hpagent'
 import { NodeHttpHandler } from '@smithy/node-http-handler'
 import { readMacosCertificates, readLinuxCertificates, readWindowsCertificates } from './certificatesReaders'

runtimes/runtimes/util/standalone/experimentalProxyUtil.ts

@@ -1,6 +1,6 @@
 import { Workspace } from '../../../server-interface'
 
-import type { ConfigurationOptions } from 'aws-sdk'
+import { ConfigurationOptions } from 'aws-sdk2-types'
 import { HttpsProxyAgent } from 'hpagent'
 import { NodeHttpHandler } from '@smithy/node-http-handler'
 

runtimes/runtimes/util/standalone/proxyUtil.ts

@@ -1,5 +1,5 @@
-import type { Service } from 'aws-sdk'
-import { ServiceConfigurationOptions } from 'aws-sdk/lib/service'
+import { Service } from 'aws-sdk2-types'
+import { ServiceConfigurationOptions } from 'aws-sdk2-types/lib/service'
 
 // aws sdk v2 clients constructor type
 export type SDKClientConstructorV2<T, P extends ServiceConfigurationOptions> = new (config?: P) => T

runtimes/server-interface/sdk-initializator.ts

@@ -30,8 +30,8 @@ import {
     InitializeParams,
 } from '../protocol'
 import { IdentityManagement } from '../server-interface/identity-management'
-import type { Service } from 'aws-sdk'
-import { ServiceConfigurationOptions } from 'aws-sdk/lib/service'
+import { Service } from 'aws-sdk2-types'
+import { ServiceConfigurationOptions } from 'aws-sdk2-types/lib/service'
 
 /**
  * A test helper package to test Server implementations. Accepts a single callback