Set CMake policy CMP0144 to new to use <PACKAGENAME>_ROOT env vars#630
Merged
bartlettroscoe merged 1 commit intoTriBITSPub:masterfrom Mar 22, 2025
Merged
Conversation
rabartlett1972
previously approved these changes
Mar 22, 2025
Collaborator
rabartlett1972
left a comment
There was a problem hiding this comment.
I tested this locally and it made the warning go away.
See the CHANGELOG.md entry. I also added a new helper macro tribits_set_cmake_policy_if_exists() to make setting policies for different versions of CMake more robustly. Signed-off-by: Roscoe A. Bartlett <rabartl@sandia.gov>
b0f2433 to
6ad8cea
Compare
rabartlett1972
approved these changes
Mar 22, 2025
Collaborator
rabartlett1972
left a comment
There was a problem hiding this comment.
I tested this locally and it make that warning go away for Trilinos configure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eliminates warnings like:
This is part of: