fix(collections/list): remove hover background darkening in list view #8295
Conversation
It partially fixes #8267 by removing hover background darkening in list view. Progressive background darkening in nested notes still needs to be addressed.
dosubot
bot
added
the
size:XS
Summary of ChangesHello @Aitanuqui, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a targeted CSS adjustment to resolve an unintended visual behavior in the application's list view. Specifically, it removes the background darkening effect that previously occurred when users hovered over items in the list, which was only intended for the grid view. This change enhances the user experience by ensuring visual consistency and partially addresses a known UI issue. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes the hover background effect from the list view by making the CSS selector specific to the grid view. I've added one suggestion to consolidate related CSS rules for better maintainability. Overall, the change is good and achieves its goal.
| :root .note-list.grid-view .note-book-card:hover { | ||
| background-color: var(--card-background-hover-color); | ||
| transition: background-color 200ms ease-out; | ||
| } |
There was a problem hiding this comment.
For better maintainability, you could consolidate the hover styles for .note-list.grid-view .note-book-card. There's another rule for this same selector on lines 763-765 that applies a filter. You can combine them into this single rule block.
After this change, the rule at lines 763-765 will be redundant and can be removed.
::root .note-list.grid-view .note-book-card:hover {
background-color: var(--card-background-hover-color);
transition: background-color 200ms ease-out;
filter: contrast(105%);
}There was a problem hiding this comment.
What about you consolidate it at lines 763-765 so it is closer to the rest of the grid view styles?
1 participant
It partially fixes #8267 by removing hover background darkening in list view. Progressive background darkening in nested notes still needs to be addressed.