Skip to content

Conversation

@Aitanuqui
Copy link
Contributor

It partially fixes #8267 by removing hover background darkening in list view. Progressive background darkening in nested notes still needs to be addressed.

It partially fixes TriliumNext#8267 by removing hover background darkening in list view. Progressive background darkening in nested notes still needs to be addressed.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 7, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Aitanuqui, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the visual behavior of note cards by adjusting their hover effects. It specifically removes an unintended background darkening effect when hovering over note cards in the standard list view, while ensuring the desired hover effect remains active for note cards displayed in the grid view. This change partially resolves a reported UI issue related to inconsistent hover styling.

Highlights

  • Targeted Hover Effect: The background darkening on hover for note cards is now specifically applied only when the note list is in "grid-view" mode.
  • Fix for List View: The general hover background darkening has been removed from the default list view, addressing the issue of unwanted darkening in that context.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the hover background darkening effect from note cards in the list view, while retaining it for the grid view. The change is implemented by removing a general hover rule and consolidating the hover styles into the grid-view-specific rule. My feedback includes a suggestion to improve CSS selector consistency, which will enhance maintainability.

@@ -761,6 +756,8 @@ li.dropdown-item a.dropdown-item-button:focus-visible {
}

.note-list.grid-view .note-book-card:hover {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the nearby :active selector for the same element (:root .note-list.grid-view .note-book-card:active), it would be good to prefix this selector with :root as well. This will improve the maintainability and readability of the stylesheet.

:root .note-list.grid-view .note-book-card:hover {

@Aitanuqui Aitanuqui closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable hover and nested background darkening in list view

1 participant