Scripts/ShrineOfTheStorm: Implement Tidesage Council encounter #31187
+616
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyr97
reviewed
Aug 2, 2025
Nyr97
reviewed
Aug 5, 2025
Comment on lines
+475
to
+476
| if (unit->GetEntry() != BOSS_BROTHER_IRONHULL || unit->GetEntry() != BOSS_GALECALLER_FAYE) | ||
| return; |
There was a problem hiding this comment.
wrong condition, it should be if it's NOT x AND it's NOT Y, return:
Suggested change
| if (unit->GetEntry() != BOSS_BROTHER_IRONHULL || unit->GetEntry() != BOSS_GALECALLER_FAYE) | |
| return; | |
| if (unit->GetEntry() != BOSS_BROTHER_IRONHULL && unit->GetEntry() != BOSS_GALECALLER_FAYE) | |
| return; |
Nyr97
reviewed
Aug 5, 2025
src/server/scripts/KulTiras/ShrineOfTheStorm/boss_tidesage_council.cpp
Outdated
Show resolved
Hide resolved
Nyr97
reviewed
Aug 5, 2025
src/server/scripts/KulTiras/ShrineOfTheStorm/boss_tidesage_council.cpp
Outdated
Show resolved
Hide resolved
Nyr97
reviewed
Aug 5, 2025
src/server/scripts/KulTiras/ShrineOfTheStorm/boss_tidesage_council.cpp
Outdated
Show resolved
Hide resolved
Nyr97
reviewed
Aug 5, 2025
src/server/scripts/KulTiras/ShrineOfTheStorm/boss_tidesage_council.cpp
Outdated
Show resolved
Hide resolved
Nyr97
reviewed
Aug 5, 2025
| { | ||
| for (uint32 bossesData : TidesageData) | ||
| { | ||
| if (Creature* council = instance->GetCreature(bossesData)) |
There was a problem hiding this comment.
I'd check if council is alive and not in combat, neither of the functions inside it prevent DoZoneInCombat from happening
Nyr97
reviewed
Aug 5, 2025
|
|
||
| enum TidesageCouncilTexts | ||
| { | ||
| SAY_AGGRO = 0, |
There was a problem hiding this comment.
this is minimal but i would use 0-4 for generic ones, and then 5-X for specific ones to keep it ordered, it would also help with future boss scripted where you keep 0-4 for the same purpose
mdX7
reviewed
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Tests performed:
Tested in-game