c++ SCript for the Quest Zero Tolerance and spellfix spell_zuldrak_gymers_grab #31196

Thor1423 · 2025-08-05T18:17:26Z

I personally think that the whole thing can be designed better with c++, so here is my c++ idea

Here's my link with the C++ code and two videos
#30286 (comment)

UPDATE `creature_template` SET `AIName` = '', `ScriptName` = 'npc_servant_of_drakuru' WHERE `entry` = 28802;

 -- Servant of Drakuru smart ai
SET @ENTRY := 28802;
DELETE FROM `smart_scripts` WHERE `source_type` = 0 AND `entryOrGuid` = @ENTRY;

-- Servant of Drakuru Text
DELETE FROM `creature_text` WHERE `CreatureID`=@ENTRY;
INSERT INTO `creature_text` (`CreatureID`, `GroupID`, `ID`, `Text`, `Type`, `Language`, `Probability`, `Emote`, `Duration`, `Sound`, `BroadcastTextId`, `TextRange`, `comment`) VALUES
(@ENTRY, 0, 0, "Darmuk must die, mon!", 12, 0, 100, 0, 0, 0, 28884, 0, 'Servant of Drakuru - Say on Charm');

This is my first PR so please forgive me if I forgot something

based on this Commit TrinityCore#30286 (comment) I personally think that the whole thing can be designed better with c++, so here is my c++ idea Here's my link with the C++ code and two videos TrinityCore#30286 (comment)

Fix Register AI Class

Nyr97 · 2025-08-05T20:54:00Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+        }
+
+        enum Events
+        {


this must be outside of class

Nyr97 · 2025-08-05T20:54:19Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+        npc_servant_of_drakuruAI(Creature* creature)
+            : ScriptedAI(creature), _controller(nullptr), _checkTimer(1000), _controlled(false)
+        {
+            _events.Reset();


we don't manipulate EventMap in ctor

Nyr97 · 2025-08-05T20:54:39Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+
+        void SpellHit(WorldObject* caster, SpellInfo const* spell) override
+        {
+            if (!spell)


SpellInfo cannot ever be null here

Nyr97 · 2025-08-05T20:55:02Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+            {
+                if (caster && caster->GetTypeId() == TYPEID_PLAYER)
+                {
+                    Player* player = caster->ToPlayer();


this is redundant, cast ToPlayer and then check for nullability in that case

Nyr97 · 2025-08-05T20:55:33Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+
+        void UpdateAI(uint32 diff) override
+        {
+            if (_controlled)


this checks per ms, use an event to delay the checks by 500ms-1s

Essentially, the script does exactly what it's supposed to, and therefore there were no compilation errors in the logs or in the game.

I assumed it was solid code that I had created with the help of a friend from back then. You can see in the video that it does what it's supposed to.

But okay, I'm not a professional programmer and I'm not afraid of corrections during the learning phase. So I'm sorry my first attempt isn't good enough for you.

Just because a piece of code doesn't throw errors, exceptions, or cause crashes doesn't mean it's optimized to its best. You don't need to check that particular case every tick of Update, it's okay to delay it by 500-1000ms to optimize resources; it's not a deal of not being good enough for me, it's just a suggestion you can take or leave.

Just because a piece of code doesn't throw errors, exceptions, or cause crashes doesn't mean it's optimized to its best. You don't need to check that particular case every tick of Update, it's okay to delay it by 500-1000ms to optimize resources; it's not a deal of not being good enough for me, it's just a suggestion you can take or leave.

That wasn't what I meant. I'll take it to heart and try to optimize it. As I said, I'm still learning and don't know everything yet, and this is my first attempt at a PR. When I get home, I'll try to implement it, so there's a one-time delay. You're right that once the action is completed, no further updates are necessary.

@Nyr97

I have now revised it and would like to submit it as is.

#include "ScriptMgr.h" #include "Creature.h" #include "SpellInfo.h" #include "Unit.h" #include "Player.h" #include "ScriptedCreature.h" enum { SPELL_TRIGGER_ID = 52390, NPC_ENTRY_CONTROLLED = 28805, QUEST_ID = 12686, SPELL_CAST = 50361, EVENT_CAST_SPELL = 1, EVENT_CONTROL_CHECK = 2, }; class npc_servant_of_drakuru : public CreatureScript { public: npc_servant_of_drakuru() : CreatureScript("npc_servant_of_drakuru") {} struct npc_servant_of_drakuruAI : public ScriptedAI { npc_servant_of_drakuruAI(Creature* creature): ScriptedAI(creature), _controller(nullptr), _controlled(false) { } void JustEngagedWith(Unit* /*who*/) override { _events.Reset(); _events.ScheduleEvent(EVENT_CAST_SPELL, 4s); _events.ScheduleEvent(EVENT_CONTROL_CHECK, 1s); } void SpellHit(WorldObject* caster, SpellInfo const* spell) override { if (spell->Id == SPELL_TRIGGER_ID) { if (Player* player = caster->ToPlayer()) { if (player->GetQuestStatus(QUEST_ID) == QUEST_STATUS_INCOMPLETE) { _controller = player; Talk(0); me->UpdateEntry(NPC_ENTRY_CONTROLLED); me->SetHealth(me->GetMaxHealth()); _controlled = true; } } } } void UpdateAI(uint32 diff) override { _events.Update(diff); while (uint32 eventId = _events.ExecuteEvent()) { switch (eventId) { case EVENT_CAST_SPELL: if (!_controlled) { if (Unit* target = me->GetVictim()) me->CastSpell(target, SPELL_CAST, true); } _events.ScheduleEvent(EVENT_CAST_SPELL, 12s, 14s); break; case EVENT_CONTROL_CHECK: if (_controlled) { if (me->GetCharmerOrOwner() != _controller) { if (_controller && _controller->GetQuestStatus(QUEST_ID) == QUEST_STATUS_INCOMPLETE) me->DespawnOrUnsummon(1s, 3s); _controlled = false; _controller = nullptr; _events.Reset(); return; } } _events.ScheduleEvent(EVENT_CONTROL_CHECK, 1s); break; } } if (!_controlled) ScriptedAI::UpdateAI(diff); } private: EventMap _events; Player* _controller; bool _controlled; }; CreatureAI* GetAI(Creature* creature) const override { return new npc_servant_of_drakuruAI(creature); } }; void AddSC_npc_servant_of_drakuru() { new npc_servant_of_drakuru(); }

Code optimization and I hope it's ok this time ^^

CraftedRO · 2025-08-06T09:45:07Z

you may want to put sql code in a file inside 3.3.5 update path too.

Thor1423 · 2025-08-06T09:58:17Z

you may want to put sql code in a file inside 3.3.5 update path too.

Do I have to send it separately as a PR?

CraftedRO · 2025-08-06T10:03:37Z

separate file, in same PR, you can temporary name it 2025_99_99_99_world.sql

Thor1423 · 2025-08-06T10:07:16Z

separate file, in same PR, you can temporary name it 2025_99_99_99_world.sql

Okay, I'll give it a try ^^
Have you tested the script?

SQL for the PR Quest Zero Tolerance: TrinityCore#31196

Thor1423 · 2025-08-06T10:16:18Z

ok i have added the SQL File

Missing Healing Effect after grabbed the Storm Cloud with this fix now works

Fix Spellscript spell_zuldrak_gymers_grab

Faq · 2025-08-06T18:35:44Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+        if (GetHitCreature()->GetEntry() == NPC_STORM_CLOUD) // Storm Cloud
+        GetHitCreature()->CastSpell(GetCaster(), SPELL_HEALING_WINDS, true); // Healing Winds


Suggested change

if (GetHitCreature()->GetEntry() == NPC_STORM_CLOUD) // Storm Cloud

GetHitCreature()->CastSpell(GetCaster(), SPELL_HEALING_WINDS, true); // Healing Winds

if (GetHitCreature()->GetEntry() == NPC_STORM_CLOUD) // Storm Cloud

GetHitCreature()->CastSpell(GetCaster(), SPELL_HEALING_WINDS, true); // Healing Winds

Isnt here missing space ?

Thor1423 · 2025-08-07T12:24:06Z

Apparently, reading the comments here, they don't want my fixes.

It was worth a try.

Naddley · 2025-08-09T10:56:03Z

Apparently, reading the comments here, they don't want my fixes.

It was worth a try.

you get feedback for your code and now its "We dont want your code"?
Well...

Nyr97 · 2025-08-10T07:40:21Z

Yeah, I don't understand that, I gave a few good changes to apply 😢

Thor1423 · 2025-08-10T07:47:48Z

you get feedback for your code and now its "We dont want your code"?
Well...

I've made the improvement but it still doesn't seem to be good enough, so I assume there's no interest.

Yeah, I don't understand that, I gave a few good changes to apply 😢

I implemented this with the last update.

Nyr97 · 2025-08-10T07:51:15Z

Applying feedback that has been offered doesn't mean that it'll get reviewed the moment it happens. Merging takes time.

offl · 2025-08-10T09:05:22Z

I've made the improvement but it still doesn't seem to be good enough, so I assume there's no interest.

The fact you're having reviews doesn't mean someone don't want your PR to be merged, it means there are improvements to be made so it can be merged (that's the whole purpose of making PRs)

offl · 2025-08-10T09:06:24Z

sql/updates/world/3.3.5/2025_99_99_99_world.sql

+-- Servant of Drakuru Text
+DELETE FROM `creature_text` WHERE `CreatureID`=@ENTRY;
+INSERT INTO `creature_text` (`CreatureID`, `GroupID`, `ID`, `Text`, `Type`, `Language`, `Probability`, `Emote`, `Duration`, `Sound`, `BroadcastTextId`, `TextRange`, `comment`) VALUES
+(@ENTRY, 0, 0, "Darmuk must die, mon!", 12, 0, 100, 0, 0, 0, 28884, 0, 'Servant of Drakuru - Say on Charm');


Missing newline

offl · 2025-08-10T09:07:55Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+
+enum
+{
+    SPELL_TRIGGER_ID = 52390,


Spells should have original name defined, in this case SPELL_CHARM_DRAKURU_SERVANT

offl · 2025-08-10T09:08:26Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+{
+    SPELL_TRIGGER_ID = 52390,
+    NPC_ENTRY_CONTROLLED = 28805,
+    NPC_ENTRY_NORMAL = 28802,


Same with NPC entries, original names

offl · 2025-08-10T09:08:39Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+    SPELL_TRIGGER_ID = 52390,
+    NPC_ENTRY_CONTROLLED = 28805,
+    NPC_ENTRY_NORMAL = 28802,
+    QUEST_ID = 12686,


Same with quests, original names

offl · 2025-08-10T09:09:23Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+    QUEST_ID = 12686,
+    SPELL_CAST = 50361,
+
+    EVENT_CAST_SPELL = 1,


Events should be named after spells used in events

offl · 2025-08-10T09:09:52Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+                    if (player->GetQuestStatus(QUEST_ID) == QUEST_STATUS_INCOMPLETE)
+                    {
+                        _controller = player;
+                        Talk(0);


Magic number, it should be defined in enum

offl · 2025-08-10T09:12:02Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+                    if (!_controlled)
+                    {
+                        if (Unit* target = me->GetVictim())
+                            me->CastSpell(target, SPELL_CAST, true);


Casting combat spells with triggered cast flag (true means triggered full mask) is a big no without a real reason. In this case creature will cast that spell even if polymorphed

offl · 2025-08-10T09:12:41Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+                        if (Unit* target = me->GetVictim())
+                            me->CastSpell(target, SPELL_CAST, true);
+                    }
+                    _events.ScheduleEvent(EVENT_CAST_SPELL, 12s, 14s);


Better to use _events.Repeat(12s, 14s);

offl · 2025-08-10T09:14:01Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+                        if (me->GetCharmerOrOwner() != _controller)
+                        {
+                            if (_controller && _controller->GetQuestStatus(QUEST_ID) == QUEST_STATUS_INCOMPLETE)
+                                me->DespawnOrUnsummon(1s, 3s);


You're using forceRespawnTimer but creature can't respawn (and shouldn't)
It should be just

me->DespawnOrUnsummon(1s);

offl · 2025-08-10T09:14:30Z

src/server/scripts/Northrend/zone_zuldrak.cpp

+                            return;
+                        }
+                    }
+                    _events.ScheduleEvent(EVENT_CONTROL_CHECK, 1s);


_events.Repeat(1s);

offl · 2025-08-10T09:15:11Z

src/server/scripts/Northrend/zone_zuldrak.cpp

@@ -1224,4 +1328,5 @@ void AddSC_zuldrak()
    RegisterSpellScript(spell_zuldrak_zuldrak_rat);
    RegisterSpellScript(spell_zuldrak_gymers_grab);
    RegisterSpellScript(spell_zuldrak_gymers_throw);
+    new npc_servant_of_drakuru();


Please use new register model with RegisterCreatureAI, you can find examples in this file

offl · 2025-08-10T09:28:07Z

sql/updates/world/3.3.5/2025_99_99_99_world.sql

@@ -0,0 +1,10 @@
+UPDATE `creature_template` SET `AIName` = '', `ScriptName` = 'npc_servant_of_drakuru' WHERE `entry` = 28802;
+


SQL files should start with

--

offl · 2025-08-10T09:29:12Z

src/server/scripts/Northrend/zone_zuldrak.cpp

@@ -1196,6 +1201,105 @@ class spell_zuldrak_gymers_throw : public SpellScript
    }
 };

+//Quest 12686 Zero Tolerance
+
+enum


enum ZeroTolerance

offl · 2025-08-10T09:29:33Z

src/server/scripts/Northrend/zone_zuldrak.cpp

@@ -1196,6 +1201,105 @@ class spell_zuldrak_gymers_throw : public SpellScript
    }
 };

+//Quest 12686 Zero Tolerance


/*###### ## Quest 12686: Zero Tolerance ######*/

this one is not a standard and can be ignored most likely.

Well, I use it every time
Now majority of new or updated zone scripts has it

Update zone_zuldrak.cpp

0e76ff4

based on this Commit TrinityCore#30286 (comment) I personally think that the whole thing can be designed better with c++, so here is my c++ idea Here's my link with the C++ code and two videos TrinityCore#30286 (comment)

github-actions bot added the Branch-3.3.5a label Aug 5, 2025

Thor1423 changed the title ~~Update zone_zuldrak.cpp~~ c++ SCript for the Quest Zero Tolerance Aug 5, 2025

Update zone_zuldrak.cpp

0b37e9d

Fix Register AI Class

Nyr97 reviewed Aug 5, 2025

View reviewed changes

src/server/scripts/Northrend/zone_zuldrak.cpp Outdated

}

enum Events

{

Copy link

Contributor

Nyr97 Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this must be outside of class

Nyr97 reviewed Aug 5, 2025

View reviewed changes

Update zone_zuldrak.cpp

76dfca2

Code optimization and I hope it's ok this time ^^

Add files via upload

9149c33

SQL for the PR Quest Zero Tolerance: TrinityCore#31196

Thor1423 added 2 commits August 6, 2025 17:58

Fix Spellscript spell_zuldrak_gymers_grab

f3986cb

Missing Healing Effect after grabbed the Storm Cloud with this fix now works

Merge pull request #1 from Thor1423/Thor1423-patch-1

81bb8b9

Fix Spellscript spell_zuldrak_gymers_grab

Thor1423 changed the title ~~c++ SCript for the Quest Zero Tolerance~~ c++ SCript for the Quest Zero Tolerance and spellfix spell_zuldrak_gymers_grab Aug 6, 2025

Faq reviewed Aug 6, 2025

View reviewed changes

Thor1423 mentioned this pull request Aug 7, 2025

DB/Quest: Zero Tolerance updates #30286

Closed

offl reviewed Aug 10, 2025

View reviewed changes

src/server/scripts/Northrend/zone_zuldrak.cpp

return;

}

}

_events.ScheduleEvent(EVENT_CONTROL_CHECK, 1s);

Copy link

Contributor

offl Aug 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_events.Repeat(1s);

offl reviewed Aug 10, 2025

View reviewed changes

		if (GetHitCreature()->GetEntry() == NPC_STORM_CLOUD) // Storm Cloud
		GetHitCreature()->CastSpell(GetCaster(), SPELL_HEALING_WINDS, true); // Healing Winds

		@@ -0,0 +1,10 @@
		UPDATE `creature_template` SET `AIName` = '', `ScriptName` = 'npc_servant_of_drakuru' WHERE `entry` = 28802;

c++ SCript for the Quest Zero Tolerance and spellfix spell_zuldrak_gymers_grab #31196

Are you sure you want to change the base?

c++ SCript for the Quest Zero Tolerance and spellfix spell_zuldrak_gymers_grab #31196

Uh oh!

Conversation

Thor1423 commented Aug 5, 2025 • edited by Aokromes Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Thor1423 Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CraftedRO commented Aug 6, 2025

Uh oh!

Thor1423 commented Aug 6, 2025

Uh oh!

CraftedRO commented Aug 6, 2025

Uh oh!

Thor1423 commented Aug 6, 2025

Uh oh!

Thor1423 commented Aug 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Thor1423 commented Aug 7, 2025

Uh oh!

Naddley commented Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nyr97 commented Aug 10, 2025

Uh oh!

Thor1423 commented Aug 10, 2025

Uh oh!

Nyr97 commented Aug 10, 2025

Uh oh!

offl commented Aug 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Thor1423 commented Aug 5, 2025 •

edited by Aokromes

Loading

Thor1423 Aug 6, 2025 •

edited

Loading

Naddley commented Aug 9, 2025 •

edited

Loading