-
Notifications
You must be signed in to change notification settings - Fork 0
Added generator actions to keep the generated files fresh. #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
47a99d2 to
44a06ac
Compare
b5353c0 to
f02b336
Compare
f02b336 to
a82c650
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements automated workflows to keep generated type files up to date and adjusts the NuGet publish job accordingly, while temporarily disabling the HTML-based method parser.
- Commented out the
ParseMethodsimplementation inDefinitionLoader.cs - Updated the NuGet publish workflow to depend on the generation step for PRs
- Added two new workflows: one to regenerate and commit types on PRs, and one to run weekly scheduled updates
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Generator/DefinitionLoader.cs | Temporarily disabled HTML parsing logic in ParseMethods |
| .github/workflows/nuget-publish.yml | Conditional needs on generate-and-commit for PR events |
| .github/workflows/generate-types-pr.yml | New PR-triggered workflow to run generator and commit updated types |
| .github/workflows/generate-types-autopr.yml | New scheduled workflow to regenerate types weekly and open a pull request |
Comments suppressed due to low confidence (1)
Generator/DefinitionLoader.cs:365
- Commenting out the entire parsing loop leaves
ParseMethodsnon-functional and always returns an empty list. Consider restoring the logic behind a feature flag or replacing it with a stub that clearly indicates unimplemented functionality.
//var tBodyIndex = methodBlock.IndexOf("<tbody");
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds automated workflows to regenerate and commit updated types, and temporarily disables HTML method parsing to streamline generator behavior.
- Comments out the
ParseMethodsimplementation inDefinitionLoader.cs. - Refines the NuGet publish workflow to depend on the type-generation job for PRs.
- Introduces two new GitHub Actions workflows: one to auto-update generated types on pull requests, and one to schedule weekly updates.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Generator/DefinitionLoader.cs | Commented out the method-parsing loop, leaving ParseMethods return empty. |
| .github/workflows/nuget-publish.yml | Added conditional needs and if to build job for PR vs. other events. |
| .github/workflows/generate-types-pr.yml | New workflow to run generator on PRs and commit updates if needed. |
| .github/workflows/generate-types-autopr.yml | New scheduled workflow to regenerate types weekly and open/update a PR. |
Comments suppressed due to low confidence (2)
Generator/DefinitionLoader.cs:364
- Because the parsing loop is fully commented out,
ParseMethodswill always return an empty list, disabling method definition loading. Restore or properly stub the logic if this behavior was not intended.
List<MethodDefinition> result = [];
.github/workflows/nuget-publish.yml:13
- GitHub Actions does not support conditional expressions in
needs; this will likely break the workflow definition. Define explicit job dependencies or split into separate jobs instead.
needs: ${{ github.event_name == 'pull_request' && 'generate-and-commit' || '' }}
No description provided.