Skip to content

Conversation

@Triogap
Copy link
Owner

@Triogap Triogap commented May 29, 2025

No description provided.

@Triogap Triogap force-pushed the task/generator-actions branch from 47a99d2 to 44a06ac Compare May 29, 2025 22:42
@Triogap Triogap force-pushed the task/generator-actions branch from b5353c0 to f02b336 Compare May 29, 2025 22:59
@Triogap Triogap force-pushed the task/generator-actions branch from f02b336 to a82c650 Compare May 29, 2025 23:01
@Triogap Triogap requested a review from Copilot May 30, 2025 13:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements automated workflows to keep generated type files up to date and adjusts the NuGet publish job accordingly, while temporarily disabling the HTML-based method parser.

  • Commented out the ParseMethods implementation in DefinitionLoader.cs
  • Updated the NuGet publish workflow to depend on the generation step for PRs
  • Added two new workflows: one to regenerate and commit types on PRs, and one to run weekly scheduled updates

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
Generator/DefinitionLoader.cs Temporarily disabled HTML parsing logic in ParseMethods
.github/workflows/nuget-publish.yml Conditional needs on generate-and-commit for PR events
.github/workflows/generate-types-pr.yml New PR-triggered workflow to run generator and commit updated types
.github/workflows/generate-types-autopr.yml New scheduled workflow to regenerate types weekly and open a pull request
Comments suppressed due to low confidence (1)

Generator/DefinitionLoader.cs:365

  • Commenting out the entire parsing loop leaves ParseMethods non-functional and always returns an empty list. Consider restoring the logic behind a feature flag or replacing it with a stub that clearly indicates unimplemented functionality.
//var tBodyIndex = methodBlock.IndexOf("<tbody");

@Triogap Triogap requested a review from Copilot May 30, 2025 14:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds automated workflows to regenerate and commit updated types, and temporarily disables HTML method parsing to streamline generator behavior.

  • Comments out the ParseMethods implementation in DefinitionLoader.cs.
  • Refines the NuGet publish workflow to depend on the type-generation job for PRs.
  • Introduces two new GitHub Actions workflows: one to auto-update generated types on pull requests, and one to schedule weekly updates.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
Generator/DefinitionLoader.cs Commented out the method-parsing loop, leaving ParseMethods return empty.
.github/workflows/nuget-publish.yml Added conditional needs and if to build job for PR vs. other events.
.github/workflows/generate-types-pr.yml New workflow to run generator on PRs and commit updates if needed.
.github/workflows/generate-types-autopr.yml New scheduled workflow to regenerate types weekly and open/update a PR.
Comments suppressed due to low confidence (2)

Generator/DefinitionLoader.cs:364

  • Because the parsing loop is fully commented out, ParseMethods will always return an empty list, disabling method definition loading. Restore or properly stub the logic if this behavior was not intended.
List<MethodDefinition> result = [];

.github/workflows/nuget-publish.yml:13

  • GitHub Actions does not support conditional expressions in needs; this will likely break the workflow definition. Define explicit job dependencies or split into separate jobs instead.
needs: ${{ github.event_name == 'pull_request' && 'generate-and-commit' || '' }}

@Triogap Triogap merged commit 950a851 into master May 30, 2025
2 checks passed
@Triogap Triogap deleted the task/generator-actions branch May 30, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants