Task/use channel in generator #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a channel-based approach to load class definitions concurrently and generate code, replacing the previous synchronous flow.
- Utilize System.Threading.Channels to stream ClassDefinition data from the DefinitionLoader to the CodeGenerator concurrently.
- Refactor methods in DefinitionLoader and CodeGenerator to use async patterns and channel operations.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Generator/Program.cs | Implements channel creation and concurrent execution with Task.WhenAll. |
| Generator/DefinitionLoader.cs | Refactors loading logic to use a ChannelWriter and converts parsing methods to async. |
| Generator/CodeGenerator.cs | Updates constructor and GenerateCode method to consume class definitions via a ChannelReader. |
Triogap
force-pushed
the
task/use-channel-in-generator
branch
from
6c97e62 to
456bd96
Compare
Triogap
force-pushed
the
task/use-channel-in-generator
branch
from
d63e47c to
35c2008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.