Conversation
danmcd
changed the title
|
Real bugid now present. Moving out of draft, and testing on the two netboot cases for starters. Will ALSO need PR for sdc-booter. |
|
|
||
| agent { | ||
| label joyCommonLabels(image_ver: '19.4.0') | ||
| label joyCommonLabels(image_ver: '24.4.1', pi: '20210826T002459Z') |
There was a problem hiding this comment.
NOTE: It is possible that for ipxe a joyent-retro image will not be needed. If I can remove the pi spec from here it would be nice.
|
|
||
| # our base image is triton-origin-x86_64-24.4.1 | ||
| BASE_IMAGE_UUID = 41bd4100-eb86-409a-85b0-e649aadf6f62 | ||
| BUILD_PLATFORM = 20210826T002459Z |
There was a problem hiding this comment.
Same here with BUILD_PLATFORM.
|
Test notes updated. |
nshalman
left a comment
nshalman
left a comment
There was a problem hiding this comment.
Assuming the testing notes are referring to a build based on these changes, looks good to me.
|
So the build with a joyent-retro PI did work and is on Kebecloud now. I'd like to remove the PI requirement to see if it builds on a native 24.4.1 zone. It'll be easier to diff binaries. |
|
I'm still upset I have to bring out the bigger stick of ENGBLD_SKIP_VALIDATE_BUILDENV, but it appears the suggested ENGBLD_SKIP_VALIDATE_BUILD_PLATFORM. Hmmm... do shell functions need exported environments? If so then maybe I needed to |
|
Okay, it just isn't going to work. Reverting to previously-approved change (and that we'll need to continue with smartos-retro... 🙃 ). |
3 participants
Will need to assign this a real bugid and slap it on Kebecloud to test all three boot varieties.