Skip to content

Fix terraform outputs#169

Open
vinmazzi wants to merge 2 commits intoTritonDataCenter:masterfrom
vinmazzi:fix-terraform-output
Open

Fix terraform outputs#169
vinmazzi wants to merge 2 commits intoTritonDataCenter:masterfrom
vinmazzi:fix-terraform-output

Conversation

@vinmazzi
Copy link

This pull request fixes an issue thread that is first described on #161.

Issue:
terraform -module option:
In order to get the authentication values returned by rancher, triton-kubernetes uses the old terraform output -module <module_name> option. Terraform has deprecated this option and is no longer saving modules output on it's tfstate.
In order to save the outputs back on the tfstate file I had to move it to the terraform module implementation, this way when terraform output is executed it returns all rancher outputs that are required by triton-kubernetes create cluster.

@vinmazzi
Copy link
Author

This change is related to the issue #161.

@blackwood821
Copy link

blackwood821 commented Mar 28, 2022

@vinmazzi I ran into #161 when recently testing out triton-kubernetes. Despite the issue, I decided to test out https://github.com/joyent/docker-machine-driver-triton in Rancher. It didn't work out of the box but after debugging and some code modifications I got it working from within Rancher so now I can spin up Triton VMs as k8s nodes directly from the Rancher UI. It seems like this repository is a workaround for Rancher not knowing how to create Triton VMs. If this is something you or anyone else is interested in I can commit my changes to a fork.

@vinmazzi vinmazzi requested a review from bahamat April 7, 2022 12:48
@danmcd danmcd requested review from a team and removed request for bahamat July 21, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants