Open
Conversation
Author
|
This change is related to the issue #161. |
|
@vinmazzi I ran into #161 when recently testing out triton-kubernetes. Despite the issue, I decided to test out https://github.com/joyent/docker-machine-driver-triton in Rancher. It didn't work out of the box but after debugging and some code modifications I got it working from within Rancher so now I can spin up Triton VMs as k8s nodes directly from the Rancher UI. It seems like this repository is a workaround for Rancher not knowing how to create Triton VMs. If this is something you or anyone else is interested in I can commit my changes to a fork. |
bahamat
reviewed
Mar 30, 2022
bahamat
suggested changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue thread that is first described on #161.
Issue:
terraform -module option:
In order to get the authentication values returned by rancher, triton-kubernetes uses the old terraform output -module <module_name> option. Terraform has deprecated this option and is no longer saving modules output on it's tfstate.
In order to save the outputs back on the tfstate file I had to move it to the terraform module implementation, this way when terraform output is executed it returns all rancher outputs that are required by triton-kubernetes create cluster.