Skip to content

Comments

chore: add structured options#28

Merged
yordis merged 1 commit intomainfrom
yordis/feat-server-opts-3
Nov 8, 2025
Merged

chore: add structured options#28
yordis merged 1 commit intomainfrom
yordis/feat-server-opts-3

Conversation

@yordis
Copy link
Member

@yordis yordis commented Nov 8, 2025

No description provided.

@cursor
Copy link

cursor bot commented Nov 8, 2025

PR Summary

Encapsulates plugin flags into a GenerateOptions struct and refactors generator functions to accept and use this options object.

  • Generator refactor (cmd/protoc-gen-elixir-grpc/main.go)
    • Introduce GenerateOptions to hold PackagePrefix, HandlerModulePrefix, HTTPTranscode, Codecs, Compressors.
    • Build opts from parsed flags and pass through generation pipeline.
    • Update function signatures to accept opts instead of multiple params:
      • generateElixirFile, generateServiceModule, generateMethodDelegate, generateHandlerModuleName, generateFilePath.
    • Replace direct flag uses with opts fields across module/file/method generation.

Written by Cursor Bugbot for commit 94f6345. This will update automatically on new commits. Configure here.

@coderabbitai
Copy link

coderabbitai bot commented Nov 8, 2025

Warning

Rate limit exceeded

@yordis has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 33 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 7ecda53 and 94f6345.

📒 Files selected for processing (1)
  • cmd/protoc-gen-elixir-grpc/main.go (10 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch yordis/feat-server-opts-3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yordis yordis marked this pull request as ready for review November 8, 2025 04:51
@yordis yordis force-pushed the yordis/feat-server-opts-3 branch 3 times, most recently from 9fef160 to 2466a38 Compare November 8, 2025 04:53
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis force-pushed the yordis/feat-server-opts-3 branch from 2466a38 to 94f6345 Compare November 8, 2025 04:54
@yordis yordis merged commit 2944151 into main Nov 8, 2025
4 checks passed
@yordis yordis deleted the yordis/feat-server-opts-3 branch November 8, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant